third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h - Issue 1439333002: Service Worker: Add Clients.get(id)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h

Issue 1439333002: Service Worker: Add Clients.get(id) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unnecessary condition Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/Clients.idl ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h

index d4fd0708dc6533d3e1faae1ca477dd9d0410dd1c..4bed79ff1568bc9dd0d3f075e7a1dda252478110 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h

@@ -16,11 +16,16 @@

namespace blink {

class ExecutionContext;

+class ScriptPromiseResolver;

class ScriptState;

class MODULES_EXPORT ServiceWorkerClient : public GarbageCollectedFinalized<ServiceWorkerClient>, public ScriptWrappable {

DEFINE_WRAPPERTYPEINFO();

public:

+ // To be used by CallbackPromiseAdapter.

+ using WebType = OwnPtr<WebServiceWorkerClientInfo>;

+ static ServiceWorkerClient* take(ScriptPromiseResolver*, PassOwnPtr<WebServiceWorkerClientInfo>);

static ServiceWorkerClient* create(const WebServiceWorkerClientInfo&);

virtual ~ServiceWorkerClient();