Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 1439333002: Service Worker: Add Clients.get(id) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary condition Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.h
diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h
index fcc86a4e755500f04d1c23ac49ee8d1135f342e2..95109ba13d8249703088cc0bc7c7ffabd0dcc5a2 100644
--- a/content/browser/service_worker/service_worker_version.h
+++ b/content/browser/service_worker/service_worker_version.h
@@ -535,6 +535,9 @@ class CONTENT_EXPORT ServiceWorkerVersion
// Message handlers.
+ // This corresponds to the spec's get(id) steps.
+ void OnGetClient(int request_id, const std::string& client_uuid);
+
// This corresponds to the spec's matchAll(options) steps.
void OnGetClients(int request_id,
const ServiceWorkerClientQueryOptions& options);
@@ -544,7 +547,6 @@ class CONTENT_EXPORT ServiceWorkerVersion
void OnOpenWindow(int request_id, GURL url);
void OnOpenWindowFinished(int request_id,
ServiceWorkerStatusCode status,
- const std::string& client_uuid,
const ServiceWorkerClientInfo& client_info);
void OnSetCachedMetadata(const GURL& url, const std::vector<char>& data);
@@ -562,15 +564,13 @@ class CONTENT_EXPORT ServiceWorkerVersion
const GURL& url);
void OnNavigateClientFinished(int request_id,
ServiceWorkerStatusCode status,
- const std::string& client_uuid,
- const ServiceWorkerClientInfo& client);
+ const ServiceWorkerClientInfo& client_info);
void OnSkipWaiting(int request_id);
void OnClaimClients(int request_id);
void OnPongFromWorker();
void OnFocusClientFinished(int request_id,
- const std::string& client_uuid,
- const ServiceWorkerClientInfo& client);
+ const ServiceWorkerClientInfo& client_info);
void OnRegisterForeignFetchScopes(const std::vector<GURL>& sub_scopes,
const std::vector<url::Origin>& origins);
@@ -583,6 +583,9 @@ class CONTENT_EXPORT ServiceWorkerVersion
void DidSkipWaiting(int request_id);
+ void OnGetClientFinished(int request_id,
+ const ServiceWorkerClientInfo& client_info);
+
void OnGetClientsFinished(int request_id, ServiceWorkerClients* clients);
// The timeout timer periodically calls OnTimeoutTimer, which stops the worker

Powered by Google App Engine
This is Rietveld 408576698