Chromium Code Reviews Chromium Code Reviews
Issue 1439333002:
Service Worker: Add Clients.get(id) (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get.html |
| diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..ceb0c29f51174535270c854734be324a3a6fab20 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get.html |
| @@ -0,0 +1,70 @@ |
| +<!DOCTYPE html> |
|
nhiroki
2016/02/18 01:40:27
This tests only the case where there are window cl
nhiroki
2016/02/18 02:18:09
FYI: I think it's ok to ship this feature (to make
jungkees
2016/02/18 15:02:20
Okay. I'll do that in a separate CL.
jungkees
2016/02/18 15:02:20
I will do so.
|
| +<title>Service Worker: Clients.get</title> |
| +<script src="../resources/testharness.js"></script> |
| +<script src="../resources/testharnessreport.js"></script> |
| +<script src="../resources/get-host-info.js"></script> |
| +<script src="resources/test-helpers.js"></script> |
| +<script> |
| +var scope = 'resources/clients-get-frame.html'; |
| +var t = async_test('Test Clients.get()'); |
| +var clientIds = []; |
|
nhiroki
2016/02/17 02:40:28
"Write variable identifiers and function names in
jungkees
2016/02/17 14:01:12
Sorry for having missed them. Thanks for the point
|
| +var frame; |
| +t.step(function() { |
| + service_worker_unregister_and_register( |
| + t, 'resources/clients-get-worker.js', scope) |
| + .then(function(registration) { |
| + add_completion_callback(function() { registration.unregister(); }); |
| + return wait_for_state(t, registration.installing, 'activated'); |
| + }) |
| + .then(function() { |
| + return with_iframe(scope + '#1'); |
| + }) |
| + .then(function(frame1) { |
| + add_completion_callback(function() { frame1.remove(); }); |
| + frame1.focus(); |
| + return wait_for_clientId(); |
| + }) |
| + .then(function(clientId) { |
|
nhiroki
2016/02/17 02:40:28
client_id
jungkees
2016/02/17 14:01:12
Done.
|
| + clientIds.push(clientId); |
| + return with_iframe(scope + '#2'); |
| + }) |
| + .then(function(frame2) { |
| + frame = frame2; |
| + add_completion_callback(function() { frame2.remove(); }); |
| + return wait_for_clientId(); |
| + }) |
| + .then(function(clientId) { |
|
nhiroki
2016/02/17 02:40:28
ditto.
jungkees
2016/02/17 14:01:12
Done.
|
| + clientIds.push(clientId, 'invalid-id'); |
| + var channel = new MessageChannel(); |
| + channel.port1.onmessage = t.step_func(on_message); |
| + frame.contentWindow.navigator.serviceWorker.controller.postMessage( |
| + {port:channel.port2, clientIds:clientIds}, [channel.port2]); |
| + }) |
| + .catch(unreached_rejection(t)); |
| + }); |
| + |
| +function wait_for_clientId() { |
| + return new Promise(function(resolve, reject) { |
| + function get_client_id(e) { |
| + window.removeEventListener('message', get_client_id); |
| + resolve(e.data.clientId); |
| + } |
| + window.addEventListener('message', get_client_id, false); |
| + }); |
| +} |
| + |
| +var expected = [ |
| + /* visibilityState, focused, url, frameType */ |
| + ['visible', true, new URL(scope + '#1', location).toString(), 'nested'], |
|
nhiroki
2016/02/17 02:40:28
"normalizeURL(scope) + '#1'" might work?
jungkees
2016/02/17 14:01:12
Yes, that works. Addressed.
|
| + ['visible', false, new URL(scope + '#2', location).toString(), 'nested'], |
| + undefined |
| +]; |
| + |
| +function on_message(e) { |
| + assert_equals(e.data.length, 3); |
| + assert_array_equals(e.data[0], expected[0]); |
| + assert_array_equals(e.data[1], expected[1]); |
| + assert_equals(e.data[2], expected[2]); |
| + service_worker_unregister_and_done(t, scope); |
|
nhiroki
2016/02/17 02:40:28
You don't have to explicitly run 'unregister' here
jungkees
2016/02/17 14:01:12
Without this line, it ends up being a timeout erro
zino
2016/02/17 18:38:13
I think you can use the "promise_test" instead of
nhiroki
2016/02/18 01:40:27
Did you call "t.done()"?
jungkees
2016/02/18 15:02:20
Correct it by using "promise_test".
|
| +} |
| +</script> |
