Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1779)

Unified Diff: content/browser/service_worker/service_worker_client_utils.h

Issue 1439333002: Service Worker: Add Clients.get(id) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_client_utils.h
diff --git a/content/browser/service_worker/service_worker_client_utils.h b/content/browser/service_worker/service_worker_client_utils.h
index 258268e1e0d2cbe93c698a3970add5fddb7fd2a8..2e3305e2c09de1a636e696e1c0e2767a5d8e0f82 100644
--- a/content/browser/service_worker/service_worker_client_utils.h
+++ b/content/browser/service_worker/service_worker_client_utils.h
@@ -27,6 +27,7 @@ using NavigationCallback =
base::Callback<void(ServiceWorkerStatusCode status,
const std::string& client_uuid,
const ServiceWorkerClientInfo& client_info)>;
+using ClientCallback = base::Callback<void(const ServiceWorkerClientInfo&)>;
zino 2016/02/05 06:21:44 nit: There was the same callback type in service_w
jungkees 2016/02/12 15:03:21 Removed ClientCallback in favor of ServiceWorkerPr
using ServiceWorkerClients = std::vector<ServiceWorkerClientInfo>;
using ClientsCallback = base::Callback<void(ServiceWorkerClients* clients)>;
@@ -47,6 +48,13 @@ void NavigateClient(const GURL& url,
const base::WeakPtr<ServiceWorkerContextCore>& context,
const NavigationCallback& callback);
+// Gets a client matched by |id|. |callback| is called with the client
nhiroki 2016/02/08 06:27:02 nit: |id| -> |client_uuid|
jungkees 2016/02/12 15:03:21 Done.
+// information on completion.
+void GetClient(const base::WeakPtr<ServiceWorkerVersion>& controller,
+ const std::string& client_uuid,
+ const base::WeakPtr<ServiceWorkerContextCore>& context,
+ const ClientCallback& callback);
+
// Collects clients matched with |options|. |callback| is called with the client
// information sorted in MRU order (most recently focused order) on completion.
void GetClients(const base::WeakPtr<ServiceWorkerVersion>& controller,

Powered by Google App Engine
This is Rietveld 408576698