Service Worker: Add Clients.get(id)

third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/clients-get-worker.js

+self.onfetch = function(e) {
+  if (e.request.url.indexOf("clients-get-frame.html") >= 0) {
+    if (e.clientId === null) {

[nhiroki, 2016/02/08 06:27:03]

Can you add a comment like this?

// On navigation, the client id should be null.

[jungkees, 2016/02/12 15:03:22]

Done.

+      e.respondWith(fetch(e.request));
+    } else {
+      e.respondWith(Response.error());
+    }
+    return;
+  }
+  e.respondWith(new Response(e.clientId));
+};
+
+self.onmessage = function(e) {
+  var port = e.data.port;
+  if (e.data.message == 'get_client_ids') {

[nhiroki, 2016/02/08 06:27:03]

The first if-block is almost equal to the second else-if-block. Can you merge
them? For example, posting an array that contains only one client id from
clients-get-other-origin.html for the 'get_other_client_id' case.

[jungkees, 2016/02/12 15:03:22]

I merged them but posted undefined instead of [undefined] as [undefined] doesn't
seem to be structured cloned across the message passing.

+    var clientIds = e.data.clientIds;
+    var message = [];
+
+    Promise.all(
+        clientIds.map(function(clientId) {
+          return self.clients.get(clientId);
+        }).concat(self.clients.get("invalid-id"))
+      ).then(function(clients) {
+        clients.forEach(function(client) {
+            if (client instanceof Client) {
+              message.push([client.visibilityState,
+                            client.focused,
+                            client.url,
+                            client.frameType]);
+            } else {
+              message.push(client);
+            }
+          });
+        port.postMessage(message);
+      });
+  } else if (e.data.message == 'get_other_client_id') {
+    var clientId = e.data.clientId;
+    var message;
+
+    self.clients.get(clientId)
+      .then(function(client) {
+          if (client instanceof Client) {
+            message = [client.visibilityState,
+                       client.focused,
+                       client.url,
+                       client.frameType];
+          } else {
+            message = client;
+          }
+          port.postMessage(message);
+        });
+  }
+};