Service Worker: Add Clients.get(id)

content/common/service_worker/service_worker_client_info.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/service_worker/service_worker_client_info.h"
 
 #include "base/logging.h"
 #include "content/common/service_worker/service_worker_types.h"
 
 namespace content {
 
 ServiceWorkerClientInfo::ServiceWorkerClientInfo()
-    : page_visibility_state(blink::WebPageVisibilityStateLast),
+    : client_uuid(std::string()),
+      page_visibility_state(blink::WebPageVisibilityStateLast),
       is_focused(false),
       frame_type(REQUEST_CONTEXT_FRAME_TYPE_LAST),
       client_type(blink::WebServiceWorkerClientTypeLast),
       last_focus_time(base::TimeTicks()) {}

[nhiroki, 2016/02/03 09:39:59]

Generally, having multiple ctors is not so good because we can easily forget to
update them all when we add a new parameter in the class/struct and that results
in uninitialized parameter bugs. To avoid that, how about using "Delegated
Constructor"[1] like this?

ServiceWorkerClientInfo::ServiceWorkerClientInfo()
    : ServiceWorkerClientInfo(std::string(), ...,
WebServiceWorkerClientTypeLast) {}

[1] http://chromium-cpp.appspot.com/#core-whitelist

[jungkees, 2016/02/03 14:15:07]

Thanks for the information and the pointer! Done.

 
 ServiceWorkerClientInfo::ServiceWorkerClientInfo(
+    const std::string& client_uuid,
     blink::WebPageVisibilityState page_visibility_state,
     bool is_focused,
     const GURL& url,
     RequestContextFrameType frame_type,
     base::TimeTicks last_focus_time,
     blink::WebServiceWorkerClientType client_type)
-    : page_visibility_state(page_visibility_state),
+    : client_uuid(client_uuid),
+      page_visibility_state(page_visibility_state),
       is_focused(is_focused),
       url(url),
       frame_type(frame_type),
       client_type(client_type),
       last_focus_time(last_focus_time) {}
 
 bool ServiceWorkerClientInfo::IsEmpty() const {
   return page_visibility_state == blink::WebPageVisibilityStateLast &&
          is_focused == false &&
          url.is_empty() &&
          frame_type == REQUEST_CONTEXT_FRAME_TYPE_LAST &&
          client_type == blink::WebServiceWorkerClientTypeLast;
 }
 
 bool ServiceWorkerClientInfo::IsValid() const {
   return !IsEmpty() && !client_uuid.empty();
 }
 
 }  // namespace content