Service Worker: Add Clients.get(id)

content/browser/service_worker/service_worker_client_utils.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_CLIENT_UTILS_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_CLIENT_UTILS_H_
 
 #include <string>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/memory/weak_ptr.h"
 #include "content/common/service_worker/service_worker_status_code.h"
 
 class GURL;
 
 namespace content {
 
 class ServiceWorkerContextCore;
 class ServiceWorkerVersion;
 struct ServiceWorkerClientInfo;
 struct ServiceWorkerClientQueryOptions;
 
 namespace service_worker_client_utils {
 
 using NavigationCallback =
     base::Callback<void(ServiceWorkerStatusCode status,
                         const std::string& client_uuid,
                         const ServiceWorkerClientInfo& client_info)>;
+using ClientCallback = base::Callback<void(const ServiceWorkerClientInfo&)>;
 using ServiceWorkerClients = std::vector<ServiceWorkerClientInfo>;
 using ClientsCallback = base::Callback<void(ServiceWorkerClients* clients)>;
 
 // Opens a new window and navigates it to |url|. |callback| is called with the
 // window's client information on completion.
 void OpenWindow(const GURL& url,
                 const GURL& script_url,
                 int worker_process_id,
                 const base::WeakPtr<ServiceWorkerContextCore>& context,
                 const NavigationCallback& callback);
 
 // Navigates the client specified by |process_id| and |frame_id| to |url|.
 // |callback| is called with the client information on completion.
 void NavigateClient(const GURL& url,
                     const GURL& script_url,
                     int process_id,
                     int frame_id,
                     const base::WeakPtr<ServiceWorkerContextCore>& context,
                     const NavigationCallback& callback);
 
+// Gets a client matched by |id|. |callback| is called with the client
+// information on completion.
+void GetClient(const base::WeakPtr<ServiceWorkerVersion>& controller,
+               const std::string& id,

[nhiroki, 2016/02/03 09:39:59]

I'd prefer "client_uuid" to "id" because this class handles some ids
(process_id, frame_id) and other classes (eg. ServiceWorkerClientInfo) name this
"client_uuid".

[jungkees, 2016/02/03 14:15:07]

Agreed. Addressed.

+               const base::WeakPtr<ServiceWorkerContextCore>& context,
+               const ClientCallback& callback);
+
 // Collects clients matched with |options|. |callback| is called with the client
 // information sorted in MRU order (most recently focused order) on completion.
 void GetClients(const base::WeakPtr<ServiceWorkerVersion>& controller,
                 const ServiceWorkerClientQueryOptions& options,
                 const ClientsCallback& callback);
 
 }  // namespace service_worker_client_utils
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_CLIENT_UTILS_H_