Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 143933002: Make GetDefaultThreadStackSize() return 16M under ThreadSanitizer (Closed)

Created:
6 years, 11 months ago by Alexander Potapenko
Modified:
6 years, 11 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Make GetDefaultThreadStackSize() return 16M under ThreadSanitizer This should help some browser tests that are currently hitting the roof under TSan. BUG=335516 R=epenner@chromium.org,dvyukov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
base/threading/platform_thread_linux.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Alexander Potapenko
Eric, Dima, could you please take a look? Thanks.
6 years, 11 months ago (2014-01-21 08:19:19 UTC) #1
Dmitry Vyukov
LGTM
6 years, 11 months ago (2014-01-21 08:45:08 UTC) #2
Alexander Potapenko
+Nico as a base/ owner
6 years, 11 months ago (2014-01-21 10:07:03 UTC) #3
Alexander Potapenko
On 2014/01/21 10:07:03, Alexander Potapenko wrote: > +Nico as a base/ owner s/Nico/Nico
6 years, 11 months ago (2014-01-21 10:07:25 UTC) #4
Nico
lgtm Now deep recursion will die earlier under tsan, but I guess we don't like ...
6 years, 11 months ago (2014-01-21 20:05:43 UTC) #5
epennerAtGoogle
On 2014/01/21 20:05:43, Nico wrote: > lgtm > > Now deep recursion will die earlier ...
6 years, 11 months ago (2014-01-21 20:10:03 UTC) #6
Alexander Potapenko
On 2014/01/21 20:05:43, Nico wrote: > lgtm > > Now deep recursion will die earlier ...
6 years, 11 months ago (2014-01-22 04:30:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/143933002/1
6 years, 11 months ago (2014-01-22 04:34:00 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-22 10:43:13 UTC) #9
Message was sent while issue was closed.
Change committed as 246280

Powered by Google App Engine
This is Rietveld 408576698