Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 1439323003: Properly call string fill constructor in win shell integration unittest. (Closed)

Created:
5 years, 1 month ago by mharanczyk
Modified:
5 years, 1 month ago
Reviewers:
gab
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly call string fill constructor in win shell integration unittest. Before it was always creating string of 49 size (value of L'1') filled with random character based of size of app id string. Found it just because size after my local changes resulted in inserting forbidden space ' ' character. Committed: https://crrev.com/462944577bb126f2ddc3fab60910ed9f1e86580b Cr-Commit-Position: refs/heads/master@{#359744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/shell_integration_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
mharanczyk
Simple and small test fix, PTAL.
5 years, 1 month ago (2015-11-13 10:38:29 UTC) #3
gab
lgtm
5 years, 1 month ago (2015-11-14 14:36:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439323003/1
5 years, 1 month ago (2015-11-14 14:37:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-15 02:30:24 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-15 02:31:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/462944577bb126f2ddc3fab60910ed9f1e86580b
Cr-Commit-Position: refs/heads/master@{#359744}

Powered by Google App Engine
This is Rietveld 408576698