chrome/browser/task_management/sampling/task_manager_impl.h - Issue 1439213004: Fix various TaskManager bugs and add new enhancements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_management/sampling/task_manager_impl.h

Issue 1439213004: Fix various TaskManager bugs and add new enhancements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: V8 memory calculations are ignored for child procs that don't use it. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/task_management/providers/task.h ('K') | « chrome/browser/task_management/sampling/task_group.cc ('k') | chrome/browser/task_management/sampling/task_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_management/sampling/task_manager_impl.h

diff --git a/chrome/browser/task_management/sampling/task_manager_impl.h b/chrome/browser/task_management/sampling/task_manager_impl.h

index 264aa45a4f0b23708c7de729d7fbd5dcfb70b234..89a2ed266c946aeaea191d4a17cf84e205e1320c 100644

--- a/chrome/browser/task_management/sampling/task_manager_impl.h

+++ b/chrome/browser/task_management/sampling/task_manager_impl.h

@@ -51,6 +51,7 @@ class TaskManagerImpl :

const base::ProcessId& GetProcessId(TaskId task_id) const override;

Task::Type GetType(TaskId task_id) const override;

int64 GetNetworkUsage(TaskId task_id) const override;

+ int64 GetProcessTotalNetworkUsage(TaskId task_id) const override;

int64 GetSqliteMemoryUsed(TaskId task_id) const override;

bool GetV8Memory(TaskId task_id,

int64* allocated,