Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: chrome/browser/task_management/providers/child_process_task.h

Issue 1439213004: Fix various TaskManager bugs and add new enhancements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: V8 memory calculations are ignored for child procs that don't use it. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_management/providers/child_process_task.h
diff --git a/chrome/browser/task_management/providers/child_process_task.h b/chrome/browser/task_management/providers/child_process_task.h
index 9dc06e5c9d878817f75daeff1632f2bd1be29478..10ef412a92f203283e51f59753295ca27b0600b7 100644
--- a/chrome/browser/task_management/providers/child_process_task.h
+++ b/chrome/browser/task_management/providers/child_process_task.h
@@ -30,6 +30,7 @@ class ChildProcessTask : public Task {
int64 refresh_flags) override;
Type GetType() const override;
int GetChildProcessUniqueID() const override;
+ base::string16 GetProfileName() const override;
bool ReportsV8Memory() const;
int64 GetV8MemoryAllocated() const override;
int64 GetV8MemoryUsed() const override;
@@ -43,6 +44,10 @@ class ChildProcessTask : public Task {
int64 v8_memory_allocated_;
int64 v8_memory_used_;
+ // The name of the active user profile at the time of the construction of this
+ // task.
+ const base::string16 profile_name_;
+
// The unique ID of the child process. It is not the PID of the process.
// See |content::ChildProcessData::id|.
const int unique_child_process_id_;
@@ -51,6 +56,10 @@ class ChildProcessTask : public Task {
// |NaClTrustedProcessType|.
const int process_type_;
+ // Depending on the |process_type_|, determines whether this task uses V8
+ // memory or not.
+ const bool uses_v8_memory_;
+
DISALLOW_COPY_AND_ASSIGN(ChildProcessTask);
};

Powered by Google App Engine
This is Rietveld 408576698