Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3513)

Unified Diff: chrome/browser/task_management/sampling/task_group.cc

Issue 1439213004: Fix various TaskManager bugs and add new enhancements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: auto*& --> auto* Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_management/sampling/task_group.cc
diff --git a/chrome/browser/task_management/sampling/task_group.cc b/chrome/browser/task_management/sampling/task_group.cc
index 45c596f9717214f92cdb34eb134f0715f41a6456..929d3b8deb6fc0b06ca797505dcb70669b318bca 100644
--- a/chrome/browser/task_management/sampling/task_group.cc
+++ b/chrome/browser/task_management/sampling/task_group.cc
@@ -63,6 +63,7 @@ TaskGroup::TaskGroup(
cpu_usage_(0.0),
memory_usage_(),
gpu_memory_(-1),
+ per_process_network_usage_(-1),
#if defined(OS_WIN)
gdi_current_handles_(-1),
gdi_peak_handles_(-1),
@@ -112,9 +113,18 @@ void TaskGroup::Refresh(
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
// First refresh the enabled non-expensive resources usages on the UI thread.
- // 1- Refresh all the tasks.
- for (auto& task_pair : tasks_)
- task_pair.second->Refresh(update_interval, refresh_flags);
+ // 1- Refresh all the tasks as well as the total network usage (if enabled).
+ const bool network_usage_refresh_enabled =
+ IsResourceRefreshEnabled(REFRESH_TYPE_NETWORK_USAGE, refresh_flags);
+ per_process_network_usage_ = network_usage_refresh_enabled ? 0 : -1;
+ for (auto& task_pair : tasks_) {
+ Task* task = task_pair.second;
+ task->Refresh(update_interval, refresh_flags);
+
+ if (network_usage_refresh_enabled && task->ReportsNetworkUsage()) {
+ per_process_network_usage_ += task->network_usage();
+ }
+ }
// 2- Refresh GPU memory (if enabled).
if (IsResourceRefreshEnabled(REFRESH_TYPE_GPU_MEMORY, refresh_flags))
« no previous file with comments | « chrome/browser/task_management/sampling/task_group.h ('k') | chrome/browser/task_management/sampling/task_manager_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698