Issue 14392017: Revert r196352 "dbus: Add FakeBus"

Issue 14392017: Revert r196352 "dbus: Add FakeBus" (Closed)

Created:
7 years, 8 months ago by oshima

Modified:
7 years, 8 months ago

Reviewers:
Haruki Sato (Google.com), Haruki Sato

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert r196352 "dbus: Add FakeBus" > dbus: Add FakeBus > BUG=234078 > TEST=trybots TBR=haruki@chromium.org BUG=234078 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196410

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -48 lines)			Patch
M	chromeos/chromeos.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chromeos/dbus/mock_dbus_thread_manager_without_gmock.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	dbus/dbus.gyp	View	2 chunks	+2 lines, -4 lines	0 comments	Download
D	dbus/fake_bus.h	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	dbus/fake_bus.cc	View	1 chunk	+0 lines, -17 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

oshima

Causing a lot of leaks in ui_unittests. I tried to use scoped_ptr, but looks like ...

7 years, 8 months ago (2013-04-25 16:11:45 UTC) #1

oshima

Here is the build http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20Heapcheck/builds/16336 On 2013/04/25 16:11:45, oshima wrote: > Causing a lot of ...

7 years, 8 months ago (2013-04-25 16:12:19 UTC) #2

oshima

Committed patchset #1 manually as r196410 (presubmit successful).

7 years, 8 months ago (2013-04-25 16:13:01 UTC) #3

Haruki Sato (Google.com)

7 years, 8 months ago (2013-04-25 16:14:43 UTC) #4

Thank you again and sorry for the trouble.

On Fri, Apr 26, 2013 at 1:12 AM,  <oshima@chromium.org> wrote:
> Here is the build
>
>
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20Heap...
>
>
> On 2013/04/25 16:11:45, oshima wrote:
>>
>> Causing a lot of leaks in ui_unittests.
>> I tried to use scoped_ptr, but looks like not trivial as bus's dtor is
>> protected, and ownership is not clearly defined. (set_ibus_bus)
>
>
>> I'm reverting this as this doesn't seem to add any new functionality.
>
>
>
>
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%2520OS%2520...
>
>
> https://codereview.chromium.org/14392017/

Expand Messages | Collapse Messages