Issue 14392003: Remove unused code/data from DriveFileSystemTest.

Issue 14392003: Remove unused code/data from DriveFileSystemTest. (Closed)

Created:
7 years, 8 months ago by kinaba

Modified:
7 years, 8 months ago

Reviewers:
hidehiko

CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unused code/data from DriveFileSystemTest. After we have introduced FakeDriveService, the code and test data for loading directory entries' json is not needed and not used. We should better remove them. Along the way, moved an EXPECT_EQ statement from the AddDirectory helper function to each test case to clarify the failure position. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195448

Patch Set 1 #

Patch Set 2 : Remove more and revive one #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1138 lines)			Patch
M	chrome/browser/chromeos/drive/drive_cache_unittest.cc	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_file_system_unittest.cc	View	1	6 chunks	+5 lines, -52 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/directory_entry_atom.json	View		1 chunk	+0 lines, -86 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/directory_entry_atom2.json	View		1 chunk	+0 lines, -86 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/search_result_feed.json	View	1	1 chunk	+0 lines, -243 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/search_result_with_new_entry_feed.json	View	1	1 chunk	+0 lines, -243 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/subdir_feed.json	View	1	1 chunk	+0 lines, -236 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/uploaded_document.json	View	1	1 chunk	+0 lines, -85 lines	0 comments	Download
D	chrome/test/data/chromeos/gdata/uploaded_file.json	View	1	1 chunk	+0 lines, -103 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/14392003/7

7 years, 8 months ago (2013-04-22 05:13:11 UTC) #4

kinaba

7 years, 8 months ago (2013-04-22 05:42:28 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r195448 (presubmit successful).

Expand Messages | Collapse Messages