Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: components/update_client/update_client_internal.h

Issue 1439153002: Revert of Change the update_client task runner behavior to continue on shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/update_client/update_client.cc ('k') | extensions/browser/updater/update_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/update_client/update_client_internal.h
diff --git a/components/update_client/update_client_internal.h b/components/update_client/update_client_internal.h
index 6a5bf39b7cc0053a97c983900323aecdee98a93b..0dc98be13b4a736b326d004cf39c3481345f71b8 100644
--- a/components/update_client/update_client_internal.h
+++ b/components/update_client/update_client_internal.h
@@ -52,7 +52,6 @@
bool GetCrxUpdateState(const std::string& id,
CrxUpdateItem* update_item) const override;
bool IsUpdating(const std::string& id) const override;
- void Stop() override;
private:
~UpdateClientImpl() override;
@@ -66,15 +65,12 @@
base::ThreadChecker thread_checker_;
- // True is Stop method has been called.
- bool is_stopped_;
-
scoped_refptr<Configurator> config_;
// Contains the tasks that are pending. In the current implementation,
// only update tasks (background tasks) are queued up. These tasks are
- // pending while they are in this queue. They have not been picked up yet
- // by the update engine.
+ // pending while they are in this queue. They are not being handled for
+ // the moment.
std::queue<Task*> task_queue_;
// Contains all tasks in progress. These are the tasks that the update engine
@@ -90,6 +86,12 @@
base::ObserverList<Observer> observer_list_;
+ // Used to post responses back to the main thread.
+ scoped_refptr<base::SingleThreadTaskRunner> main_task_runner_;
+
+ // Used to execute blocking tasks.
+ scoped_refptr<base::SequencedTaskRunner> blocking_task_runner_;
+
DISALLOW_COPY_AND_ASSIGN(UpdateClientImpl);
};
« no previous file with comments | « components/update_client/update_client.cc ('k') | extensions/browser/updater/update_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698