Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 143913003: Add construction of WebSocketDeflateStream (Closed)

Created:
6 years, 11 months ago by Adam Rice
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Advertise the permessage-deflate extension and enable it when requested by the server. Also validation and parsing of the permessage-deflate extension parameters, and unit tests. BUG=280910 TEST=net_unittests --gtest_filter=WebSocket* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247545

Patch Set 1 #

Patch Set 2 : Add tests for permessage-deflate extension. #

Patch Set 3 : Miscellaneous cleanups. #

Patch Set 4 : Rebase. #

Patch Set 5 : Include Sec-WebSocket-Extensions in HandshakeInfo test. #

Total comments: 4

Patch Set 6 : Actually turn on permessage-deflate. #

Patch Set 7 : Rename per_content_takeover to per_context_takeover. #

Total comments: 2

Patch Set 8 : s/declared/defined/ #

Total comments: 2

Patch Set 9 : Rebase and add DCHECK() for extension params. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -29 lines) Patch
M net/websockets/websocket_basic_handshake_stream.h View 1 2 3 4 5 6 7 2 chunks +6 lines, -0 lines 0 comments Download
M net/websockets/websocket_basic_handshake_stream.cc View 1 2 3 4 5 6 7 8 10 chunks +125 lines, -14 lines 0 comments Download
M net/websockets/websocket_handshake_stream_create_helper.cc View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M net/websockets/websocket_handshake_stream_create_helper_test.cc View 1 2 3 4 5 6 2 chunks +39 lines, -3 lines 0 comments Download
M net/websockets/websocket_stream_test.cc View 1 2 3 4 5 6 7 chunks +220 lines, -9 lines 0 comments Download
M net/websockets/websocket_test_util.cc View 1 2 3 4 5 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Adam Rice
6 years, 11 months ago (2014-01-23 09:25:10 UTC) #1
yhirano
https://codereview.chromium.org/143913003/diff/180001/net/websockets/websocket_basic_handshake_stream.cc File net/websockets/websocket_basic_handshake_stream.cc (right): https://codereview.chromium.org/143913003/diff/180001/net/websockets/websocket_basic_handshake_stream.cc#newcode52 net/websockets/websocket_basic_handshake_stream.cc:52: bool deflate_enabled; When do you turn this flag on? ...
6 years, 11 months ago (2014-01-23 12:18:26 UTC) #2
Adam Rice
https://codereview.chromium.org/143913003/diff/180001/net/websockets/websocket_basic_handshake_stream.cc File net/websockets/websocket_basic_handshake_stream.cc (right): https://codereview.chromium.org/143913003/diff/180001/net/websockets/websocket_basic_handshake_stream.cc#newcode52 net/websockets/websocket_basic_handshake_stream.cc:52: bool deflate_enabled; On 2014/01/23 12:18:26, yhirano wrote: > When ...
6 years, 11 months ago (2014-01-24 02:04:35 UTC) #3
yhirano
lgtm https://codereview.chromium.org/143913003/diff/240001/net/websockets/websocket_basic_handshake_stream.h File net/websockets/websocket_basic_handshake_stream.h (right): https://codereview.chromium.org/143913003/diff/240001/net/websockets/websocket_basic_handshake_stream.h#newcode132 net/websockets/websocket_basic_handshake_stream.h:132: // The extension parameters. The class is declared ...
6 years, 10 months ago (2014-01-27 02:46:18 UTC) #4
Adam Rice
+tyoshino PTAL https://codereview.chromium.org/143913003/diff/240001/net/websockets/websocket_basic_handshake_stream.h File net/websockets/websocket_basic_handshake_stream.h (right): https://codereview.chromium.org/143913003/diff/240001/net/websockets/websocket_basic_handshake_stream.h#newcode132 net/websockets/websocket_basic_handshake_stream.h:132: // The extension parameters. The class is ...
6 years, 10 months ago (2014-01-27 07:30:04 UTC) #5
tyoshino (SeeGerritForStatus)
lgtm https://codereview.chromium.org/143913003/diff/390001/net/websockets/websocket_basic_handshake_stream.cc File net/websockets/websocket_basic_handshake_stream.cc (right): https://codereview.chromium.org/143913003/diff/390001/net/websockets/websocket_basic_handshake_stream.cc#newcode496 net/websockets/websocket_basic_handshake_stream.cc:496: // The HttpStreamParser object has a pointer to ...
6 years, 10 months ago (2014-01-27 16:23:24 UTC) #6
Adam Rice
https://codereview.chromium.org/143913003/diff/390001/net/websockets/websocket_basic_handshake_stream.cc File net/websockets/websocket_basic_handshake_stream.cc (right): https://codereview.chromium.org/143913003/diff/390001/net/websockets/websocket_basic_handshake_stream.cc#newcode496 net/websockets/websocket_basic_handshake_stream.cc:496: // The HttpStreamParser object has a pointer to our ...
6 years, 10 months ago (2014-01-28 08:07:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/143913003/440001
6 years, 10 months ago (2014-01-28 18:23:12 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 00:42:49 UTC) #9
Message was sent while issue was closed. 
Change committed as 247545

Powered by Google App Engine
This is Rietveld 408576698