Issue 1439113002: win: Compile getopt as C++ and wrap in crashpad namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1439113002: win: Compile getopt as C++ and wrap in crashpad namespace (Closed)

Created:
5 years, 1 month ago by scottmg

Modified:
5 years, 1 month ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

win: Compile getopt as C++ and wrap in crashpad namespace All our Main()s are in namespace crashpad already, so this just works. R=mark@chromium.org BUG=crashpad:76 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/7a7d66ca8936be27da04509cc5bcaf25ed05b86b

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -441 lines)			Patch
M	third_party/getopt/README.crashpad	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/getopt/getopt.h	View	2 chunks	+22 lines, -22 lines	0 comments	Download
D	third_party/getopt/getopt.c	View	1 chunk	+0 lines, -418 lines	0 comments	Download
A +	third_party/getopt/getopt.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	third_party/getopt/getopt.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM. But maybe you should rename the copy in Chrome to something like NaCl_getopt too, ...

5 years, 1 month ago (2015-11-12 21:57:56 UTC) #2

scottmg

Committed patchset #1 (id:1) manually as 7a7d66ca8936be27da04509cc5bcaf25ed05b86b (presubmit successful).

5 years, 1 month ago (2015-11-12 22:10:30 UTC) #3

scottmg

5 years, 1 month ago (2015-11-12 22:12:42 UTC) #4

Message was sent while issue was closed.

On 2015/11/12 21:57:56, Mark Mentovai wrote:
> LGTM. But maybe you should rename the copy in Chrome to something like
> NaCl_getopt too, it’s polluting the namespace a little bit…

Filed https://code.google.com/p/chromium/issues/detail?id=555097 against NaCl.
I'm not sure which of the copies needs to be renamed.

Expand Messages | Collapse Messages