Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/css/StyleBuilder.cpp

Issue 14391005: Rename Animation -> PrimitiveAnimation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSToStyleMap.cpp ('k') | Source/core/page/animation/AnimationBase.h » ('j') | Source/core/platform/animation/PrimitiveAnimation.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/StyleBuilder.cpp
diff --git a/Source/core/css/StyleBuilder.cpp b/Source/core/css/StyleBuilder.cpp
index 76ad795974ea9f72a4699b55ea4ad732429139f2..e1984ed48447d95fd245134ac5f683e3507f13a7 100644
--- a/Source/core/css/StyleBuilder.cpp
+++ b/Source/core/css/StyleBuilder.cpp
@@ -1626,22 +1626,22 @@ public:
};
template <typename T,
- T (Animation::*getterFunction)() const,
- void (Animation::*setterFunction)(T),
- bool (Animation::*testFunction)() const,
- void (Animation::*clearFunction)(),
+ T (PrimitiveAnimation::*getterFunction)() const,
+ void (PrimitiveAnimation::*setterFunction)(T),
+ bool (PrimitiveAnimation::*testFunction)() const,
+ void (PrimitiveAnimation::*clearFunction)(),
T (*initialFunction)(),
- void (CSSToStyleMap::*mapFunction)(Animation*, CSSValue*),
+ void (CSSToStyleMap::*mapFunction)(PrimitiveAnimation*, CSSValue*),
AnimationList* (RenderStyle::*animationGetterFunction)(),
const AnimationList* (RenderStyle::*immutableAnimationGetterFunction)() const>
class ApplyPropertyAnimation {
public:
- static void setValue(Animation* animation, T value) { (animation->*setterFunction)(value); }
- static T value(const Animation* animation) { return (animation->*getterFunction)(); }
- static bool test(const Animation* animation) { return (animation->*testFunction)(); }
- static void clear(Animation* animation) { (animation->*clearFunction)(); }
+ static void setValue(PrimitiveAnimation* animation, T value) { (animation->*setterFunction)(value); }
+ static T value(const PrimitiveAnimation* animation) { return (animation->*getterFunction)(); }
+ static bool test(const PrimitiveAnimation* animation) { return (animation->*testFunction)(); }
+ static void clear(PrimitiveAnimation* animation) { (animation->*clearFunction)(); }
static T initial() { return (*initialFunction)(); }
- static void map(StyleResolver* styleResolver, Animation* animation, CSSValue* value) { (styleResolver->styleMap()->*mapFunction)(animation, value); }
+ static void map(StyleResolver* styleResolver, PrimitiveAnimation* animation, CSSValue* value) { (styleResolver->styleMap()->*mapFunction)(animation, value); }
static AnimationList* accessAnimations(RenderStyle* style) { return (style->*animationGetterFunction)(); }
static const AnimationList* animations(RenderStyle* style) { return (style->*immutableAnimationGetterFunction)(); }
@@ -1652,7 +1652,7 @@ public:
size_t i = 0, parentSize = parentList ? parentList->size() : 0;
for ( ; i < parentSize && test(parentList->animation(i)); ++i) {
if (list->size() <= i)
- list->append(Animation::create());
+ list->append(PrimitiveAnimation::create());
setValue(list->animation(i), value(parentList->animation(i)));
list->animation(i)->setAnimationMode(parentList->animation(i)->animationMode());
}
@@ -1666,10 +1666,10 @@ public:
{
AnimationList* list = accessAnimations(styleResolver->style());
if (list->isEmpty())
- list->append(Animation::create());
+ list->append(PrimitiveAnimation::create());
setValue(list->animation(0), initial());
if (propertyID == CSSPropertyWebkitTransitionProperty)
- list->animation(0)->setAnimationMode(Animation::AnimateAll);
+ list->animation(0)->setAnimationMode(PrimitiveAnimation::AnimateAll);
for (size_t i = 1; i < list->size(); ++i)
clear(list->animation(i));
}
@@ -1682,13 +1682,13 @@ public:
/* Walk each value and put it into an animation, creating new animations as needed. */
for (CSSValueListIterator i = value; i.hasMore(); i.advance()) {
if (childIndex <= list->size())
- list->append(Animation::create());
+ list->append(PrimitiveAnimation::create());
map(styleResolver, list->animation(childIndex), i.value());
++childIndex;
}
} else {
if (list->isEmpty())
- list->append(Animation::create());
+ list->append(PrimitiveAnimation::create());
map(styleResolver, list->animation(childIndex), value);
childIndex = 1;
}
@@ -2144,14 +2144,14 @@ StyleBuilder::StyleBuilder()
setPropertyHandler(CSSPropertyUnicodeBidi, ApplyPropertyDefault<EUnicodeBidi, &RenderStyle::unicodeBidi, EUnicodeBidi, &RenderStyle::setUnicodeBidi, EUnicodeBidi, &RenderStyle::initialUnicodeBidi>::createHandler());
setPropertyHandler(CSSPropertyVerticalAlign, ApplyPropertyVerticalAlign::createHandler());
setPropertyHandler(CSSPropertyVisibility, ApplyPropertyDefault<EVisibility, &RenderStyle::visibility, EVisibility, &RenderStyle::setVisibility, EVisibility, &RenderStyle::initialVisibility>::createHandler());
- setPropertyHandler(CSSPropertyWebkitAnimationDelay, ApplyPropertyAnimation<double, &Animation::delay, &Animation::setDelay, &Animation::isDelaySet, &Animation::clearDelay, &Animation::initialAnimationDelay, &CSSToStyleMap::mapAnimationDelay, &RenderStyle::accessAnimations, &RenderStyle::animations>::createHandler());
- setPropertyHandler(CSSPropertyWebkitAnimationDirection, ApplyPropertyAnimation<Animation::AnimationDirection, &Animation::direction, &Animation::setDirection, &Animation::isDirectionSet, &Animation::clearDirection, &Animation::initialAnimationDirection, &CSSToStyleMap::mapAnimationDirection, &RenderStyle::accessAnimations, &RenderStyle::animations>::createHandler());
- setPropertyHandler(CSSPropertyWebkitAnimationDuration, ApplyPropertyAnimation<double, &Animation::duration, &Animation::setDuration, &Animation::isDurationSet, &Animation::clearDuration, &Animation::initialAnimationDuration, &CSSToStyleMap::mapAnimationDuration, &RenderStyle::accessAnimations, &RenderStyle::animations>::createHandler());
- setPropertyHandler(CSSPropertyWebkitAnimationFillMode, ApplyPropertyAnimation<unsigned, &Animation::fillMode, &Animation::setFillMode, &Animation::isFillModeSet, &Animation::clearFillMode, &Animation::initialAnimationFillMode, &CSSToStyleMap::mapAnimationFillMode, &RenderStyle::accessAnimations, &RenderStyle::animations>::createHandler());
- setPropertyHandler(CSSPropertyWebkitAnimationIterationCount, ApplyPropertyAnimation<double, &Animation::iterationCount, &Animation::setIterationCount, &Animation::isIterationCountSet, &Animation::clearIterationCount, &Animation::initialAnimationIterationCount, &CSSToStyleMap::mapAnimationIterationCount, &RenderStyle::accessAnimations, &RenderStyle::animations>::createHandler());
- setPropertyHandler(CSSPropertyWebkitAnimationName, ApplyPropertyAnimation<const String&, &Animation::name, &Animation::setName, &Animation::isNameSet, &Animation::clearName, &Animation::initialAnimationName, &CSSToStyleMap::mapAnimationName, &RenderStyle::accessAnimations, &RenderStyle::animations>::createHandler());
- setPropertyHandler(CSSPropertyWebkitAnimationPlayState, ApplyPropertyAnimation<EAnimPlayState, &Animation::playState, &Animation::setPlayState, &Animation::isPlayStateSet, &Animation::clearPlayState, &Animation::initialAnimationPlayState, &CSSToStyleMap::mapAnimationPlayState, &RenderStyle::accessAnimations, &RenderStyle::animations>::createHandler());
- setPropertyHandler(CSSPropertyWebkitAnimationTimingFunction, ApplyPropertyAnimation<const PassRefPtr<TimingFunction>, &Animation::timingFunction, &Animation::setTimingFunction, &Animation::isTimingFunctionSet, &Animation::clearTimingFunction, &Animation::initialAnimationTimingFunction, &CSSToStyleMap::mapAnimationTimingFunction, &RenderStyle::accessAnimations, &RenderStyle::animations>::createHandler());
+ setPropertyHandler(CSSPropertyWebkitAnimationDelay, ApplyPropertyAnimation<double, &PrimitiveAnimation::delay, &PrimitiveAnimation::setDelay, &PrimitiveAnimation::isDelaySet, &PrimitiveAnimation::clearDelay, &PrimitiveAnimation::initialAnimationDelay, &CSSToStyleMap::mapAnimationDelay, &RenderStyle::accessAnimations, &RenderStyle::animations>::createHandler());
+ setPropertyHandler(CSSPropertyWebkitAnimationDirection, ApplyPropertyAnimation<PrimitiveAnimation::AnimationDirection, &PrimitiveAnimation::direction, &PrimitiveAnimation::setDirection, &PrimitiveAnimation::isDirectionSet, &PrimitiveAnimation::clearDirection, &PrimitiveAnimation::initialAnimationDirection, &CSSToStyleMap::mapAnimationDirection, &RenderStyle::accessAnimations, &RenderStyle::animations>::createHandler());
+ setPropertyHandler(CSSPropertyWebkitAnimationDuration, ApplyPropertyAnimation<double, &PrimitiveAnimation::duration, &PrimitiveAnimation::setDuration, &PrimitiveAnimation::isDurationSet, &PrimitiveAnimation::clearDuration, &PrimitiveAnimation::initialAnimationDuration, &CSSToStyleMap::mapAnimationDuration, &RenderStyle::accessAnimations, &RenderStyle::animations>::createHandler());
+ setPropertyHandler(CSSPropertyWebkitAnimationFillMode, ApplyPropertyAnimation<unsigned, &PrimitiveAnimation::fillMode, &PrimitiveAnimation::setFillMode, &PrimitiveAnimation::isFillModeSet, &PrimitiveAnimation::clearFillMode, &PrimitiveAnimation::initialAnimationFillMode, &CSSToStyleMap::mapAnimationFillMode, &RenderStyle::accessAnimations, &RenderStyle::animations>::createHandler());
+ setPropertyHandler(CSSPropertyWebkitAnimationIterationCount, ApplyPropertyAnimation<double, &PrimitiveAnimation::iterationCount, &PrimitiveAnimation::setIterationCount, &PrimitiveAnimation::isIterationCountSet, &PrimitiveAnimation::clearIterationCount, &PrimitiveAnimation::initialAnimationIterationCount, &CSSToStyleMap::mapAnimationIterationCount, &RenderStyle::accessAnimations, &RenderStyle::animations>::createHandler());
+ setPropertyHandler(CSSPropertyWebkitAnimationName, ApplyPropertyAnimation<const String&, &PrimitiveAnimation::name, &PrimitiveAnimation::setName, &PrimitiveAnimation::isNameSet, &PrimitiveAnimation::clearName, &PrimitiveAnimation::initialAnimationName, &CSSToStyleMap::mapAnimationName, &RenderStyle::accessAnimations, &RenderStyle::animations>::createHandler());
+ setPropertyHandler(CSSPropertyWebkitAnimationPlayState, ApplyPropertyAnimation<EAnimPlayState, &PrimitiveAnimation::playState, &PrimitiveAnimation::setPlayState, &PrimitiveAnimation::isPlayStateSet, &PrimitiveAnimation::clearPlayState, &PrimitiveAnimation::initialAnimationPlayState, &CSSToStyleMap::mapAnimationPlayState, &RenderStyle::accessAnimations, &RenderStyle::animations>::createHandler());
+ setPropertyHandler(CSSPropertyWebkitAnimationTimingFunction, ApplyPropertyAnimation<const PassRefPtr<TimingFunction>, &PrimitiveAnimation::timingFunction, &PrimitiveAnimation::setTimingFunction, &PrimitiveAnimation::isTimingFunctionSet, &PrimitiveAnimation::clearTimingFunction, &PrimitiveAnimation::initialAnimationTimingFunction, &CSSToStyleMap::mapAnimationTimingFunction, &RenderStyle::accessAnimations, &RenderStyle::animations>::createHandler());
setPropertyHandler(CSSPropertyWebkitAppearance, ApplyPropertyDefault<ControlPart, &RenderStyle::appearance, ControlPart, &RenderStyle::setAppearance, ControlPart, &RenderStyle::initialAppearance>::createHandler());
setPropertyHandler(CSSPropertyWebkitAspectRatio, ApplyPropertyAspectRatio::createHandler());
setPropertyHandler(CSSPropertyWebkitBackfaceVisibility, ApplyPropertyDefault<EBackfaceVisibility, &RenderStyle::backfaceVisibility, EBackfaceVisibility, &RenderStyle::setBackfaceVisibility, EBackfaceVisibility, &RenderStyle::initialBackfaceVisibility>::createHandler());
@@ -2267,10 +2267,10 @@ StyleBuilder::StyleBuilder()
setPropertyHandler(CSSPropertyWebkitTransformOriginY, ApplyPropertyLength<&RenderStyle::transformOriginY, &RenderStyle::setTransformOriginY, &RenderStyle::initialTransformOriginY>::createHandler());
setPropertyHandler(CSSPropertyWebkitTransformOriginZ, ApplyPropertyComputeLength<float, &RenderStyle::transformOriginZ, &RenderStyle::setTransformOriginZ, &RenderStyle::initialTransformOriginZ>::createHandler());
setPropertyHandler(CSSPropertyWebkitTransformStyle, ApplyPropertyDefault<ETransformStyle3D, &RenderStyle::transformStyle3D, ETransformStyle3D, &RenderStyle::setTransformStyle3D, ETransformStyle3D, &RenderStyle::initialTransformStyle3D>::createHandler());
- setPropertyHandler(CSSPropertyWebkitTransitionDelay, ApplyPropertyAnimation<double, &Animation::delay, &Animation::setDelay, &Animation::isDelaySet, &Animation::clearDelay, &Animation::initialAnimationDelay, &CSSToStyleMap::mapAnimationDelay, &RenderStyle::accessTransitions, &RenderStyle::transitions>::createHandler());
- setPropertyHandler(CSSPropertyWebkitTransitionDuration, ApplyPropertyAnimation<double, &Animation::duration, &Animation::setDuration, &Animation::isDurationSet, &Animation::clearDuration, &Animation::initialAnimationDuration, &CSSToStyleMap::mapAnimationDuration, &RenderStyle::accessTransitions, &RenderStyle::transitions>::createHandler());
- setPropertyHandler(CSSPropertyWebkitTransitionProperty, ApplyPropertyAnimation<CSSPropertyID, &Animation::property, &Animation::setProperty, &Animation::isPropertySet, &Animation::clearProperty, &Animation::initialAnimationProperty, &CSSToStyleMap::mapAnimationProperty, &RenderStyle::accessTransitions, &RenderStyle::transitions>::createHandler());
- setPropertyHandler(CSSPropertyWebkitTransitionTimingFunction, ApplyPropertyAnimation<const PassRefPtr<TimingFunction>, &Animation::timingFunction, &Animation::setTimingFunction, &Animation::isTimingFunctionSet, &Animation::clearTimingFunction, &Animation::initialAnimationTimingFunction, &CSSToStyleMap::mapAnimationTimingFunction, &RenderStyle::accessTransitions, &RenderStyle::transitions>::createHandler());
+ setPropertyHandler(CSSPropertyWebkitTransitionDelay, ApplyPropertyAnimation<double, &PrimitiveAnimation::delay, &PrimitiveAnimation::setDelay, &PrimitiveAnimation::isDelaySet, &PrimitiveAnimation::clearDelay, &PrimitiveAnimation::initialAnimationDelay, &CSSToStyleMap::mapAnimationDelay, &RenderStyle::accessTransitions, &RenderStyle::transitions>::createHandler());
+ setPropertyHandler(CSSPropertyWebkitTransitionDuration, ApplyPropertyAnimation<double, &PrimitiveAnimation::duration, &PrimitiveAnimation::setDuration, &PrimitiveAnimation::isDurationSet, &PrimitiveAnimation::clearDuration, &PrimitiveAnimation::initialAnimationDuration, &CSSToStyleMap::mapAnimationDuration, &RenderStyle::accessTransitions, &RenderStyle::transitions>::createHandler());
+ setPropertyHandler(CSSPropertyWebkitTransitionProperty, ApplyPropertyAnimation<CSSPropertyID, &PrimitiveAnimation::property, &PrimitiveAnimation::setProperty, &PrimitiveAnimation::isPropertySet, &PrimitiveAnimation::clearProperty, &PrimitiveAnimation::initialAnimationProperty, &CSSToStyleMap::mapAnimationProperty, &RenderStyle::accessTransitions, &RenderStyle::transitions>::createHandler());
+ setPropertyHandler(CSSPropertyWebkitTransitionTimingFunction, ApplyPropertyAnimation<const PassRefPtr<TimingFunction>, &PrimitiveAnimation::timingFunction, &PrimitiveAnimation::setTimingFunction, &PrimitiveAnimation::isTimingFunctionSet, &PrimitiveAnimation::clearTimingFunction, &PrimitiveAnimation::initialAnimationTimingFunction, &CSSToStyleMap::mapAnimationTimingFunction, &RenderStyle::accessTransitions, &RenderStyle::transitions>::createHandler());
setPropertyHandler(CSSPropertyWebkitUserDrag, ApplyPropertyDefault<EUserDrag, &RenderStyle::userDrag, EUserDrag, &RenderStyle::setUserDrag, EUserDrag, &RenderStyle::initialUserDrag>::createHandler());
setPropertyHandler(CSSPropertyWebkitUserModify, ApplyPropertyDefault<EUserModify, &RenderStyle::userModify, EUserModify, &RenderStyle::setUserModify, EUserModify, &RenderStyle::initialUserModify>::createHandler());
setPropertyHandler(CSSPropertyWebkitUserSelect, ApplyPropertyDefault<EUserSelect, &RenderStyle::userSelect, EUserSelect, &RenderStyle::setUserSelect, EUserSelect, &RenderStyle::initialUserSelect>::createHandler());
« no previous file with comments | « Source/core/css/CSSToStyleMap.cpp ('k') | Source/core/page/animation/AnimationBase.h » ('j') | Source/core/platform/animation/PrimitiveAnimation.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698