Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2138)

Issue 1439093003: Make CFWL_WidgetMgr{Delegate} inherit from IFWL_WidgetMgr{Delegate}. (Closed)

Created:
5 years, 1 month ago by Tom Sepez
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Make CFWL_WidgetMgr{Delegate} inherit from IFWL_WidgetMgr{Delegate}. C-style casting masked a fairly serious botch, where an CFWL_ type would get cast to an IFWL_ type, and later we'd invoke virtual methods against the IFWL_ type. Without the proper inheritance, there's no reason to believe that the vtables for each of these would line up with each other. Fixing the inheritence allows us to remove the c-style casts. I'm guessing these were added to make this compile without having to understand the true nature of the flaw. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e8131137dabd2e1dcf1bcdf49e81ee6c9ae26413

Patch Set 1 #

Patch Set 2 : Added one comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -27 lines) Patch
M xfa/src/fwl/src/core/fwl_appimp.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_widgetmgrimp.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/src/fwl/src/core/include/fwl_widgetmgrimp.h View 1 2 chunks +26 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, there are a pile of these, if one greps for IFWL_ types that don't ...
5 years, 1 month ago (2015-11-13 01:18:47 UTC) #2
Lei Zhang
lgtm
5 years, 1 month ago (2015-11-13 05:09:09 UTC) #3
Tom Sepez
5 years, 1 month ago (2015-11-13 18:14:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e8131137dabd2e1dcf1bcdf49e81ee6c9ae26413 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698