Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1439083003: Revert "[es6] Optimize String{Starts, Ends}With" (Closed)

Created:
5 years, 1 month ago by rossberg
Modified:
5 years, 1 month ago
Reviewers:
dehrenberg
CC:
v8-reviews_googlegroups.com, Jakob Kummerow, skomski
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "[es6] Optimize String{Starts, Ends}With" This reverts commit b7db5cd9c761de2f15112ce4d46c7ade8c749ac0 (https://codereview.chromium.org/1324353002/). Our internal dashboard shows that this patch has introduced massive (3x) performance regressions for string ops. This is probably due to it repeatedly invoking %_StringCharCodeAt in a loop, which is far from cheap (has to dispatch on one of our 30+ string representations each time). TBR=dehrenberg@chromium.org BUG= Committed: https://crrev.com/84b4e1d4336454908a6824e81d5fa5257003eaf0 Cr-Commit-Position: refs/heads/master@{#31981}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -23 lines) Patch
M src/js/string.js View 4 chunks +11 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439083003/1
5 years, 1 month ago (2015-11-13 12:41:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 13:17:37 UTC) #4
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:21:27 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84b4e1d4336454908a6824e81d5fa5257003eaf0
Cr-Commit-Position: refs/heads/master@{#31981}

Powered by Google App Engine
This is Rietveld 408576698