Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: net/proxy/proxy_resolver_v8_tracing.h

Issue 1439053002: Change ProxyResolver::GetProxyForURL() to take a scoped_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ToT Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/proxy_resolver_v8_tracing.h
diff --git a/net/proxy/proxy_resolver_v8_tracing.h b/net/proxy/proxy_resolver_v8_tracing.h
index f5f66cf7486797d0c6282f7dab361b2942cfa283..2f0957db508d18d65826682796a645602a131307 100644
--- a/net/proxy/proxy_resolver_v8_tracing.h
+++ b/net/proxy/proxy_resolver_v8_tracing.h
@@ -51,19 +51,12 @@ class NET_EXPORT ProxyResolverV8Tracing {
// runs asynchronously and notifies the result by running |callback|. If the
// result code is OK then the request was successful and |results| contains
// the proxy resolution information. If |request| is non-null, |*request| is
- // written to, and can be passed to CancelRequest().
+ // written to and can be cancelled by reset().
virtual void GetProxyForURL(const GURL& url,
ProxyInfo* results,
const CompletionCallback& callback,
- ProxyResolver::RequestHandle* request,
+ scoped_ptr<ProxyResolver::Request>* request,
scoped_ptr<Bindings> bindings) = 0;
-
- // Cancels |request|.
- virtual void CancelRequest(ProxyResolver::RequestHandle request) = 0;
-
- // Gets the LoadState for |request|.
- virtual LoadState GetLoadState(
- ProxyResolver::RequestHandle request) const = 0;
};
// A factory for ProxyResolverV8Tracing instances. The default implementation,

Powered by Google App Engine
This is Rietveld 408576698