Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: net/proxy/proxy_resolver_v8_tracing.h

Issue 1439053002: Change ProxyResolver::GetProxyForURL() to take a scoped_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Restore refptr due windows error Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/proxy_resolver_v8_tracing.h
diff --git a/net/proxy/proxy_resolver_v8_tracing.h b/net/proxy/proxy_resolver_v8_tracing.h
index f5f66cf7486797d0c6282f7dab361b2942cfa283..d8b974b7fc2a2c00cacab1cc0ca2da26303dc93e 100644
--- a/net/proxy/proxy_resolver_v8_tracing.h
+++ b/net/proxy/proxy_resolver_v8_tracing.h
@@ -19,6 +19,7 @@ class HostResolver;
// ProxyResolverV8Tracing is a non-blocking proxy resolver.
class NET_EXPORT ProxyResolverV8Tracing {
public:
+ class Request : public ProxyResolver::Request {};
eroman 2016/02/24 03:08:07 Why is this needed? Can it just be declared in the
// Bindings is an interface used by ProxyResolverV8Tracing to delegate
// per-request functionality. Each instance will be destroyed on the origin
// thread of the ProxyResolverV8Tracing when the request completes or is
@@ -55,15 +56,8 @@ class NET_EXPORT ProxyResolverV8Tracing {
virtual void GetProxyForURL(const GURL& url,
ProxyInfo* results,
const CompletionCallback& callback,
- ProxyResolver::RequestHandle* request,
+ scoped_ptr<ProxyResolver::Request>* request,
scoped_ptr<Bindings> bindings) = 0;
-
- // Cancels |request|.
- virtual void CancelRequest(ProxyResolver::RequestHandle request) = 0;
-
- // Gets the LoadState for |request|.
- virtual LoadState GetLoadState(
- ProxyResolver::RequestHandle request) const = 0;
};
// A factory for ProxyResolverV8Tracing instances. The default implementation,

Powered by Google App Engine
This is Rietveld 408576698