Chromium Code Reviews

Unified Diff: net/proxy/proxy_resolver_factory_mojo_unittest.cc

Issue 1439053002: Change ProxyResolver::GetProxyForURL() to take a scoped_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: net/proxy/proxy_resolver_factory_mojo_unittest.cc
diff --git a/net/proxy/proxy_resolver_factory_mojo_unittest.cc b/net/proxy/proxy_resolver_factory_mojo_unittest.cc
index 15d8a64d9f54751c5d957a6707a1c39f9df95544..efa37cfb2363cd1fe3f36aa77763a36613c71f69 100644
--- a/net/proxy/proxy_resolver_factory_mojo_unittest.cc
+++ b/net/proxy/proxy_resolver_factory_mojo_unittest.cc
@@ -292,14 +292,14 @@ class Request {
int WaitForResult();
const ProxyInfo& results() const { return results_; }
- LoadState load_state() { return resolver_->GetLoadState(handle_); }
+ LoadState load_state() { return handle_->GetLoadState(); }
BoundTestNetLog& net_log() { return net_log_; }
private:
ProxyResolver* resolver_;
const GURL url_;
ProxyInfo results_;
- ProxyResolver::RequestHandle handle_;
+ scoped_ptr<ProxyResolver::Request> handle_;
int error_;
TestCompletionCallback callback_;
BoundTestNetLog net_log_;
@@ -316,7 +316,7 @@ int Request::Resolve() {
}
void Request::Cancel() {
- resolver_->CancelRequest(handle_);
+ handle_.reset();
}
int Request::WaitForResult() {
@@ -838,7 +838,7 @@ TEST_F(ProxyResolverFactoryMojoTest, GetProxyForURL_DeleteInCallback) {
ProxyInfo results;
TestCompletionCallback callback;
- ProxyResolver::RequestHandle handle;
+ scoped_ptr<ProxyResolver::Request> request;
BoundNetLog net_log;
EXPECT_EQ(
OK,
@@ -846,7 +846,7 @@ TEST_F(ProxyResolverFactoryMojoTest, GetProxyForURL_DeleteInCallback) {
GURL(kExampleUrl), &results,
base::Bind(&ProxyResolverFactoryMojoTest::DeleteProxyResolverCallback,
base::Unretained(this), callback.callback()),
- &handle, net_log)));
+ &request, net_log)));
on_delete_callback_.WaitForResult();
}
@@ -858,7 +858,7 @@ TEST_F(ProxyResolverFactoryMojoTest,
ProxyInfo results;
TestCompletionCallback callback;
- ProxyResolver::RequestHandle handle;
+ scoped_ptr<ProxyResolver::Request> request;
BoundNetLog net_log;
EXPECT_EQ(
ERR_PAC_SCRIPT_TERMINATED,
@@ -866,7 +866,7 @@ TEST_F(ProxyResolverFactoryMojoTest,
GURL(kExampleUrl), &results,
base::Bind(&ProxyResolverFactoryMojoTest::DeleteProxyResolverCallback,
base::Unretained(this), callback.callback()),
- &handle, net_log)));
+ &request, net_log)));
on_delete_callback_.WaitForResult();
}

Powered by Google App Engine