Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: net/proxy/mojo_proxy_resolver_factory_impl_unittest.cc

Issue 1439053002: Change ProxyResolver::GetProxyForURL() to take a scoped_ptr<Request>* rather than a RequestHandle* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/mojo_proxy_resolver_factory_impl_unittest.cc
diff --git a/net/proxy/mojo_proxy_resolver_factory_impl_unittest.cc b/net/proxy/mojo_proxy_resolver_factory_impl_unittest.cc
index 0262d647cc1c187a051c0843d0cee08c462e0f3d..f7bceb1430eef464d26cde3f9fdd6f95db024600 100644
--- a/net/proxy/mojo_proxy_resolver_factory_impl_unittest.cc
+++ b/net/proxy/mojo_proxy_resolver_factory_impl_unittest.cc
@@ -29,15 +29,9 @@ class FakeProxyResolver : public ProxyResolverV8Tracing {
void GetProxyForURL(const GURL& url,
ProxyInfo* results,
const CompletionCallback& callback,
- ProxyResolver::RequestHandle* request,
+ scoped_ptr<ProxyResolver::Request>* request,
scoped_ptr<Bindings> bindings) override {}
- void CancelRequest(ProxyResolver::RequestHandle request) override {}
-
- LoadState GetLoadState(ProxyResolver::RequestHandle request) const override {
- return LOAD_STATE_RESOLVING_PROXY_FOR_URL;
- }
-
const base::Closure on_destruction_;
};

Powered by Google App Engine
This is Rietveld 408576698