Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: third_party/WebKit/Source/core/css/CSSCustomFontData.h

Issue 1439033002: Oilpan: tidy up CSSCustomFontData::m_fontFaceSource back ref somewhat. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use WeakPersistent Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSCustomFontData.h
diff --git a/third_party/WebKit/Source/core/css/CSSCustomFontData.h b/third_party/WebKit/Source/core/css/CSSCustomFontData.h
index 3ca52da2e57f504589a17e025893bae49fafc83e..227adfcd413da9c27c88c6e808805cdda5713d0c 100644
--- a/third_party/WebKit/Source/core/css/CSSCustomFontData.h
+++ b/third_party/WebKit/Source/core/css/CSSCustomFontData.h
@@ -23,6 +23,7 @@
#include "core/css/CSSFontFaceSource.h"
#include "platform/fonts/CustomFontData.h"
+#include "platform/heap/Handle.h"
namespace blink {
@@ -66,11 +67,13 @@ private:
m_isLoading = source->isLoading();
}
- RemoteFontFaceSource* m_fontFaceSource;
+ // TODO(Oilpan): consider moving (Custom)FontFace hierarchy to the heap,
+ // thereby making this reference a Member<>.
+ RawPtrWillBeWeakPersistent<RemoteFontFaceSource> m_fontFaceSource;
FallbackVisibility m_fallbackVisibility;
mutable bool m_isLoading;
};
-}
+} // namespace blink
#endif // CSSCustomFontData_h
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698