Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 143903021: Add disable flag around supervised user import code. (Closed)

Created:
6 years, 11 months ago by Adrian Kuegel
Modified:
6 years, 10 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Add disable flag around supervised user import code, but enable by default. This CL enables the supervised user import code in Chrome by default, but allows to disable it with a flag. In ChromeOS, the code is still not enabled by default. BUG=337101 TEST=manual, browser_test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248494

Patch Set 1 #

Patch Set 2 : Add disable flag and enable by default. #

Total comments: 2

Patch Set 3 : Address nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M chrome/browser/resources/options/manage_profile_overlay.js View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/options.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/create_profile_handler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_browsertest.js View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Adrian Kuegel
Pam, can you please review this CL?
6 years, 11 months ago (2014-01-23 10:30:13 UTC) #1
Adrian Kuegel
On 2014/01/23 10:30:13, Adrian Kuegel wrote: > Pam, can you please review this CL? I ...
6 years, 10 months ago (2014-02-03 12:12:50 UTC) #2
Pam (message me for reviews)
LGTM, with one comment below. https://codereview.chromium.org/143903021/diff/90001/chrome/common/chrome_switches.h File chrome/common/chrome_switches.h (right): https://codereview.chromium.org/143903021/diff/90001/chrome/common/chrome_switches.h#newcode27 chrome/common/chrome_switches.h:27: extern const char kAllowCreateExistingManagedUsers[]; ...
6 years, 10 months ago (2014-02-03 12:27:18 UTC) #3
Adrian Kuegel
The CQ bit was checked by akuegel@chromium.org
6 years, 10 months ago (2014-02-03 12:30:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akuegel@chromium.org/143903021/120002
6 years, 10 months ago (2014-02-03 12:30:33 UTC) #5
Adrian Kuegel
https://codereview.chromium.org/143903021/diff/90001/chrome/common/chrome_switches.h File chrome/common/chrome_switches.h (right): https://codereview.chromium.org/143903021/diff/90001/chrome/common/chrome_switches.h#newcode27 chrome/common/chrome_switches.h:27: extern const char kAllowCreateExistingManagedUsers[]; On 2014/02/03 12:27:18, Pam (also ...
6 years, 10 months ago (2014-02-03 12:34:55 UTC) #6
commit-bot: I haz the power
Change committed as 248494
6 years, 10 months ago (2014-02-03 15:06:02 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 15:06:03 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 15:06:10 UTC) #9
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698