Fixed crash on Android tcmalloc builds caused by vasprintf being incompatible to tcmalloc

Fixed crash on Android tcmalloc builds caused by vasprintf being incompatible to tcmalloc

R=esprehn@chromium.org
TEST=Compile Android build with Deep Memory Profiler support. Go to lenta.ru. Open some news pages. Should not crash.

********** Crash dump: **********
Build fingerprint: 'samsung/GT-I9100/GT-I9100:4.0.3/IML74K/XXLPQ:user/release-keys'
pid: 3431, tid: 3444  >>> org.chromium.content_shell_apk:sandboxed_process1 <<<
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 00000039
Stack frame #00  pc 02263b44  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Abort in ../../third_party/tcmalloc/chromium/src/base/abort.cc:15
Stack frame #01  pc 0226ccd8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Log in ../../third_party/tcmalloc/chromium/src/internal_logging.cc:120
Stack frame #02  pc 0227584c  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine InvalidFree in (null):0
Stack frame #03  pc 02277698  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine do_free_with_callback in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1166
Stack frame #04  pc 02277898  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine do_free in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1209
Stack frame #05  pc 0229f914  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine tc_free in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1569
Stack frame #06  pc 0158af50  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine error in (null):0
Stack frame #07  pc 0158aff8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine normalErrorHandler in ../../third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:1305
Stack frame #08  pc 01166dac  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine __xmlRaiseError in ../../third_party/libxml/src/error.c:572
Stack frame #09  pc 0116b7a8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlFatalErr in (null):0
Stack frame #10  pc 0117e424  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlParseTryOrFinish in ../../third_party/libxml/src/parser.c:11453
Stack frame #11  pc 0117ea88  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlParseChunk in ../../third_party/libxml/src/parser.c:11767
Stack frame #12  pc 0158891c  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine parseChunk in (null):0
Stack frame #13  pc 01589da0  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine doWrite in ../../third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:876
Stack frame #14  pc 01589f3c  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine append in ../../third_party/WebKit/Source/wtf/RefPtr.h:49
Stack frame #15  pc 00d07e70  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine setContent in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:70
Stack frame #16  pc 015770bc  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXML in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:70
Stack frame #17  pc 017bdd20  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXMLAttributeGetter in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:47
Stack frame #18  pc 017bddc8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXMLAttributeGetterCallback in gen/blink/bindings/V8XMLHttpRequest.cpp:219
Stack frame #19  pc 00eb86d8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Call in ../../v8/src/arguments.cc:110
Stack frame #20  pc 01024b5c  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetPropertyWithCallback in ../../v8/src/objects.cc:443
Stack frame #21  pc 010304c8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetProperty in ../../v8/src/objects.cc:971
Stack frame #22  pc 010305dc  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetProperty in ../../v8/src/objects.cc:845
Stack frame #23  pc 00fb12f8  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Load in ../../v8/src/ic.cc:875
Stack frame #24  pc 00fb1b78  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine __RT_impl_LoadIC_Miss in ../../v8/src/ic.cc:2076
Stack frame #25  pc 00fb1bd0  /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine LoadIC_Miss in (null):0

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166520

[descri, 2014-01-23 09:18:59]

Please review the fix for Android/DeepMemoryProfiler crash.

[esprehn, 2014-01-23 18:17:34]

lgtm to me but this seems to imply that vasprintf can't ever be used in our
codebase since tcmalloc will break it...

I added some other reviewers who might know a better way to solve this.

[descri, 2014-01-24 08:36:14]

On 2014/01/23 18:17:34, esprehn wrote:
> lgtm to me but this seems to imply that vasprintf can't ever be used in our
> codebase since tcmalloc will break it...

Thank you. As you see, vasprintf has already been under #ifdef there, so that
the code would compile on systems without vasprintf support. And I have not seen
any other crash with it. Probably it is not (widely) used.

[descri, 2014-01-28 12:32:16]

Hello?

[Peter Beverloo, 2014-01-28 12:34:22]

+bulach FYI

[descri, 2014-02-04 11:31:25]

On 2014/01/28 12:34:22, Peter Beverloo wrote:
> +bulach FYI

Is there anybody in there?

[descri, 2014-02-04 16:07:33]

The CQ bit was checked by descri@yandex-team.ru

[commit-bot: I haz the power, 2014-02-04 16:07:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/descri@yandex-team.ru/143903018/1

[commit-bot: I haz the power, 2014-02-04 18:44:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 18:44:35]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[descri, 2014-02-05 16:33:02]

The CQ bit was checked by descri@yandex-team.ru

[commit-bot: I haz the power, 2014-02-05 16:33:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/descri@yandex-team.ru/143903018/1

[commit-bot: I haz the power, 2014-02-05 17:57:01]

Change committed as 166520