Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 143903016: Fixed floor-of-div optimization. (Closed)

Created:
6 years, 11 months ago by Sven Panne
Modified:
6 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Fixed floor-of-div optimization. We removed an HDiv by hand which was still used by an HChange. The solution is letting dead code removal do the cleanup. Removed a fragile "optimization" (looking through an HChange), too, this obviously never triggered and is hard to get right given all our global invariants and state/type/... changes. The repro is a bit tricky, because you need inlining to make our representations and types disagree in this case. LOG=y BUG=334708 R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -21 lines) Patch
M src/hydrogen-instructions.cc View 2 chunks +1 line, -11 lines 0 comments Download
A + test/mjsunit/regress/regress-334708.js View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 11 months ago (2014-01-22 11:20:06 UTC) #1
Benedikt Meurer
LGTM
6 years, 11 months ago (2014-01-22 11:38:18 UTC) #2
Sven Panne
6 years, 11 months ago (2014-01-22 11:54:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18737 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698