Issue 143903004: Add support for component=shared_library for base_unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 143903004: Add support for component=shared_library for base_unittests. (Closed)

Created:
6 years, 11 months ago by M-A Ruel

Modified:
6 years, 11 months ago

Reviewers:
jungshik at Google

CC:
chromium-reviews, csharp, Vadim Sh.

Base URL:
https://chromium.googlesource.com/chromium/deps/icu46.git@master

Visibility:
Public.

This has to be checked in first so it can be rolled in the next CL for this bug. Description: Add support for component=shared_library for base_unittests. R=jshin@chromium.org BUG=336439 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246118

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -0 lines)			Patch
	M	icu.isolate	View		1 chunk	+24 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

M-A Ruel

This has to be checked in first so it can be rolled in the next ...

6 years, 11 months ago (2014-01-21 17:49:43 UTC) #1

jungshik at Google

On 2014/01/21 17:49:43, M-A Ruel wrote: > This has to be checked in first so ...

6 years, 11 months ago (2014-01-21 20:15:39 UTC) #2

M-A Ruel

6 years, 11 months ago (2014-01-21 21:34:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r246118 (presubmit successful).