Disable HTTP authentication dialog for XHR with credentials

Disable HTTP authentication dialog for XHR with credentials

According to the XHR[1] and Fetch[2] specifications, a request made with
URL credentials should not trigger the browser's authentication dialog
upon authentication failure, but rather return the 401 response.

[1] http://xhr.spec.whatwg.org/
[2] http://fetch.spec.whatwg.org/

BUG=31582
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247117

[Jens Widell, 2014-01-21 11:28:25]

Please take a look, when convenient.

A test for this patch would of course be nice too.  I have one locally added in
resource_dispatcher_host_browsertest.cc, but I'm unsure whether that's an
appropriate place to test this.  Testing it in LayoutTests is might be harder,
it seems authentication dialogs are canceled automatically there, making it
impossible to detect whether the patch worked.  (There are tests in LayoutTests
that test this, but they already pass, due to that.)  Please advise.

[darin (slow to review), 2014-01-23 23:37:14]

On 2014/01/21 11:28:25, Jens Lindström wrote:
> Please take a look, when convenient.
> 
> A test for this patch would of course be nice too.  I have one locally added
in
> resource_dispatcher_host_browsertest.cc, but I'm unsure whether that's an
> appropriate place to test this.  Testing it in LayoutTests is might be harder,
> it seems authentication dialogs are canceled automatically there, making it
> impossible to detect whether the patch worked.  (There are tests in
LayoutTests
> that test this, but they already pass, due to that.)  Please advise.

You may need to use a browser test for this. See
chrome/browser/ui/login/login_prompt_browsertest.cc

Otherwise, the code change seems good.

[Jens Widell, 2014-01-24 13:44:54]

On 2014/01/23 23:37:14, darin wrote:
> You may need to use a browser test for this. See
> chrome/browser/ui/login/login_prompt_browsertest.cc

That file seemed to be testing rather related things, so I added tests to it. 
Please let me know if that seems okay.

[darin (slow to review), 2014-01-25 07:37:57]

LGTM

[commit-bot: I haz the power, 2014-01-25 07:38:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jl@opera.com/143903003/50001

[commit-bot: I haz the power, 2014-01-25 10:32:17]

Change committed as 247117