Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 1439003002: [builtins] Get rid of a few %_ClassOf uses. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Get rid of a few %_ClassOf uses. With subclassing and @@toStringTag, %_ClassOf is not necessarily what you want for ES6 anymore, so better avoid relying on %_ClassOf in our builtins. R=yangguo@chromium.org Committed: https://crrev.com/dd0ba4d1320ab44500f79331fd9cd5f0f275dc34 Cr-Commit-Position: refs/heads/master@{#31953}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M src/js/harmony-atomics.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/harmony-simd.js View 3 chunks +7 lines, -6 lines 0 comments Download
M src/js/macros.py View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-12 08:13:46 UTC) #1
Benedikt Meurer
Hey Yang, This is some trivial cleanup. Please take a look. Thanks, Benedikt
5 years, 1 month ago (2015-11-12 08:15:09 UTC) #2
Yang
On 2015/11/12 08:13:46, Benedikt Meurer wrote: lgtm
5 years, 1 month ago (2015-11-12 08:15:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439003002/1
5 years, 1 month ago (2015-11-12 08:15:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 08:33:39 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:20:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd0ba4d1320ab44500f79331fd9cd5f0f275dc34
Cr-Commit-Position: refs/heads/master@{#31953}

Powered by Google App Engine
This is Rietveld 408576698