Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 14390002: Decrease the visibility of the ENABLE_THREADING_XX guards. (Closed)

Created:
7 years, 8 months ago by lgombos
Modified:
7 years, 7 months ago
CC:
blink-reviews, loislo+blink_chromium.org, jeez, yurys+blink_chromium.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Decrease the visibility of the ENABLE_THREADING_XX guards. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150286

Patch Set 1 #

Patch Set 2 : Remove ParallelJobsOpenMP #

Patch Set 3 : Rebase + remove the deleted file from the file list in gypi file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -94 lines) Patch
M Source/wtf/ParallelJobs.h View 1 1 chunk +6 lines, -3 lines 0 comments Download
M Source/wtf/ParallelJobsGeneric.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/wtf/ParallelJobsOpenMP.h View 1 1 chunk +0 lines, -81 lines 0 comments Download
M Source/wtf/Platform.h View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M Source/wtf/wtf.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (0 generated)
lgombos
Cleanup. I find encapsulation a general good practice. This is also a step forward to ...
7 years, 8 months ago (2013-04-21 12:34:55 UTC) #1
abarth-chromium
Can't we just figure out which one of these things we actually use? Do we ...
7 years, 8 months ago (2013-04-21 13:54:25 UTC) #2
abarth-chromium
I see, we use it graphics/filters. Which of these flags are actually set?
7 years, 8 months ago (2013-04-21 13:55:19 UTC) #3
lgombos
On 2013/04/21 13:55:19, abarth wrote: > I see, we use it graphics/filters. Which of these ...
7 years, 8 months ago (2013-04-22 17:05:42 UTC) #4
abarth-chromium
We should like change this code to use Chromium's thread pool, but I think we'll ...
7 years, 8 months ago (2013-04-22 17:50:36 UTC) #5
lgombos
Remove ParallelJobsOpenMP.
7 years, 8 months ago (2013-04-22 17:59:30 UTC) #6
lgombos
Any further thoughts on this ? My immediate motivation on this is to remove things ...
7 years, 7 months ago (2013-04-28 18:15:38 UTC) #7
eseidel
lgtm This looks like a fine stepping stone.
7 years, 7 months ago (2013-04-28 19:29:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14390002/7001
7 years, 7 months ago (2013-04-28 22:33:58 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_lint, webkit_tests, webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=3299
7 years, 7 months ago (2013-04-28 22:54:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14390002/7001
7 years, 7 months ago (2013-04-29 03:14:07 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_lint, webkit_tests, webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=3311
7 years, 7 months ago (2013-04-29 03:33:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14390002/7001
7 years, 7 months ago (2013-04-29 05:14:40 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_lint, webkit_tests, webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=3316
7 years, 7 months ago (2013-04-29 05:33:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14390002/7001
7 years, 7 months ago (2013-05-10 19:39:02 UTC) #15
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_lint, webkit_tests, webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=4679
7 years, 7 months ago (2013-05-10 21:21:03 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14390002/7001
7 years, 7 months ago (2013-05-11 23:38:28 UTC) #17
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=1852
7 years, 7 months ago (2013-05-11 23:54:27 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/14390002/40001
7 years, 7 months ago (2013-05-14 02:44:11 UTC) #19
commit-bot: I haz the power
7 years, 7 months ago (2013-05-14 03:19:58 UTC) #20
Message was sent while issue was closed.
Change committed as 150286

Powered by Google App Engine
This is Rietveld 408576698