perf_insights/perf_insights/corpus_query.py - Issue 1438993005: [perf-insights] Allow underscores in corpus query field names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: perf_insights/perf_insights/corpus_query.py

Issue 1438993005: [perf-insights] Allow underscores in corpus query field names (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: perf_insights/perf_insights/corpus_query.py

diff --git a/perf_insights/perf_insights/corpus_query.py b/perf_insights/perf_insights/corpus_query.py

index 46c86ecb12caf4c5be315700090590de5477b585..d55d69b1e582510adc02ecefbb6ec0193758f0f7 100644

--- a/perf_insights/perf_insights/corpus_query.py

+++ b/perf_insights/perf_insights/corpus_query.py

@@ -51,7 +51,7 @@ def _StringToValue(s):

pass

# Barewords are assumed to be fields.

- m = re.match('([a-zA-Z0-9]+)$', s)

+ m = re.match('([a-zA-Z0-9_]+)$', s)

if m:

return _ReadField(m.group(1))

« no previous file with comments | « no previous file | no next file » | no next file with comments »