Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1438953002: Update selection when an element is focused by in-document fragment link. (Closed)

Created:
5 years, 1 month ago by tkent
Modified:
5 years, 1 month ago
Reviewers:
kochi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update selection when an element is focused by in-document fragment link. Navigating to INPUT/TEXTAREA element by <a href="#foo"> sets focus on the INPUT/TEXTAREA element, but text selection was not set correctly and users were unable to input. We should not call Document::setFocusedElement, which doesn't update text selection. Use Element::focus instead. BUG=466571 Committed: https://crrev.com/7913e160229b4567595aaefbeb8a806ba7d342e7 Cr-Commit-Position: refs/heads/master@{#359413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/fragment-activation-focuses-target.html View 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/fragment-activation-focuses-target-expected.txt View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +11 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
kochi@, would you review this please?
5 years, 1 month ago (2015-11-12 03:29:32 UTC) #3
kochi
lgtm Thanks for fixing this.
5 years, 1 month ago (2015-11-12 22:18:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438953002/1
5 years, 1 month ago (2015-11-12 22:38:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 22:47:29 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 22:48:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7913e160229b4567595aaefbeb8a806ba7d342e7
Cr-Commit-Position: refs/heads/master@{#359413}

Powered by Google App Engine
This is Rietveld 408576698