Issue 1438943002: Merge to XFA: Fix / simplify CFX_FolderFontInfo::GetFontData() behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1438943002: Merge to XFA: Fix / simplify CFX_FolderFontInfo::GetFontData() behavior. (Closed)

Created:
5 years, 1 month ago by Lei Zhang

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Fix / simplify CFX_FolderFontInfo::GetFontData() behavior. The GetFontData() behavior in FPDF_SYSFONTINFO seems reasonable. Also do some code cleanup. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1425023003 . (cherry picked from commit e0c16d7461ca8317433d93835e4c36a84157cbef) Committed: https://pdfium.googlesource.com/pdfium/+/982e8905f4af77348af14fae0116fecc71f856c8

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -47 lines)			Patch
	M	core/include/fxcrt/fx_system.h	View		1 chunk	+4 lines, -6 lines	0 comments	Download
	M	core/src/fxge/ge/fx_ge_fontmap.cpp	View		7 chunks	+46 lines, -41 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

5 years, 1 month ago (2015-11-12 00:59:23 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
982e8905f4af77348af14fae0116fecc71f856c8 (presubmit successful).