Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1438933002: Add a getTarget method that returns the x86 target lowering (Closed)

Created:
5 years, 1 month ago by sehr
Modified:
5 years, 1 month ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a getTarget method that returns the x86 target lowering Remove a bit of complex repeated template naming. BUG= R=jpp@chromium.org, stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=b8e49c18c907690f989dd20971a8997fbefd7b93

Patch Set 1 #

Total comments: 1

Patch Set 2 : Consistently use class name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -146 lines) Patch
M src/IceInstX86Base.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/IceInstX86BaseImpl.h View 1 51 chunks +70 lines, -146 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sehr
PTAL.
5 years, 1 month ago (2015-11-12 00:25:24 UTC) #3
John
lgtm https://codereview.chromium.org/1438933002/diff/1/src/IceInstX86BaseImpl.h File src/IceInstX86BaseImpl.h (right): https://codereview.chromium.org/1438933002/diff/1/src/IceInstX86BaseImpl.h#newcode654 src/IceInstX86BaseImpl.h:654: auto *Target = InstX86Base<Machine>::getTarget(Func); You have some versions ...
5 years, 1 month ago (2015-11-12 00:54:03 UTC) #4
Jim Stichnoth
lgtm
5 years, 1 month ago (2015-11-12 00:59:21 UTC) #5
sehr
5 years, 1 month ago (2015-11-12 22:41:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b8e49c18c907690f989dd20971a8997fbefd7b93 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698