runtime/vm/object.cc - Issue 143893006: Relax assert in case a type is first canonicalized at run time (issue 16239).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 143893006: Relax assert in case a type is first canonicalized at run time (issue 16239). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.cc

===================================================================

--- runtime/vm/object.cc (revision 31962)

+++ runtime/vm/object.cc (working copy)

@@ -12577,7 +12577,9 @@

// Canonicalize the type arguments.

AbstractTypeArguments& type_args =

AbstractTypeArguments::Handle(isolate, arguments());

- ASSERT(type_args.IsNull() || (type_args.Length() == cls.NumTypeArguments()));

+ // In case the type is first canonicalized at runtime, its type argument

+ // vector may be longer than necessary. This is not an issue.

+ ASSERT(type_args.IsNull() || (type_args.Length() >= cls.NumTypeArguments()));

type_args = type_args.Canonicalize(trail);

set_arguments(type_args);

// The type needs to be added to the list. Grow the list if it is full.

« no previous file with comments | « no previous file | no next file » | no next file with comments »