Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Side by Side Diff: src/hydrogen.cc

Issue 143893002: Fix invalid type assumption in GenerateNumberToString(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 10259 matching lines...) Expand 10 before | Expand all | Expand 10 after
10270 void HOptimizedGraphBuilder::GenerateGetFromCache(CallRuntime* call) { 10270 void HOptimizedGraphBuilder::GenerateGetFromCache(CallRuntime* call) {
10271 return Bailout(kInlinedRuntimeFunctionGetFromCache); 10271 return Bailout(kInlinedRuntimeFunctionGetFromCache);
10272 } 10272 }
10273 10273
10274 10274
10275 // Fast support for number to string. 10275 // Fast support for number to string.
10276 void HOptimizedGraphBuilder::GenerateNumberToString(CallRuntime* call) { 10276 void HOptimizedGraphBuilder::GenerateNumberToString(CallRuntime* call) {
10277 ASSERT_EQ(1, call->arguments()->length()); 10277 ASSERT_EQ(1, call->arguments()->length());
10278 CHECK_ALIVE(VisitForValue(call->arguments()->at(0))); 10278 CHECK_ALIVE(VisitForValue(call->arguments()->at(0)));
10279 HValue* number = Pop(); 10279 HValue* number = Pop();
10280 HValue* result = BuildNumberToString(number, Type::Number(isolate())); 10280 HValue* result = BuildNumberToString(number, Type::Any(isolate()));
10281 return ast_context()->ReturnValue(result); 10281 return ast_context()->ReturnValue(result);
10282 } 10282 }
10283 10283
10284 10284
10285 // Fast call for custom callbacks. 10285 // Fast call for custom callbacks.
10286 void HOptimizedGraphBuilder::GenerateCallFunction(CallRuntime* call) { 10286 void HOptimizedGraphBuilder::GenerateCallFunction(CallRuntime* call) {
10287 // 1 ~ The function to call is not itself an argument to the call. 10287 // 1 ~ The function to call is not itself an argument to the call.
10288 int arg_count = call->arguments()->length() - 1; 10288 int arg_count = call->arguments()->length() - 1;
10289 ASSERT(arg_count >= 1); // There's always at least a receiver. 10289 ASSERT(arg_count >= 1); // There's always at least a receiver.
10290 10290
(...skipping 715 matching lines...) Expand 10 before | Expand all | Expand 10 after
11006 if (ShouldProduceTraceOutput()) { 11006 if (ShouldProduceTraceOutput()) {
11007 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 11007 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
11008 } 11008 }
11009 11009
11010 #ifdef DEBUG 11010 #ifdef DEBUG
11011 graph_->Verify(false); // No full verify. 11011 graph_->Verify(false); // No full verify.
11012 #endif 11012 #endif
11013 } 11013 }
11014 11014
11015 } } // namespace v8::internal 11015 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698