Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1438893002: Increment text pointer when the width is zero in the subpixel with center and right alignment. (Closed)

Created:
5 years, 1 month ago by herb_g
Modified:
5 years, 1 month ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Increment text pointer when the width is zero in the subpixel with center and right alignment. BUG=skia: Committed: https://skia.googlesource.com/skia/+/386127f1d431ef64bf655f39994f17daadfb5269

Patch Set 1 #

Patch Set 2 : Add test cases for code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -27 lines) Patch
M src/core/SkFindAndPlaceGlyph.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/DrawTextTest.cpp View 1 1 chunk +32 lines, -27 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
herb_g
5 years, 1 month ago (2015-11-11 23:11:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438893002/1
5 years, 1 month ago (2015-11-11 23:12:52 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-11-11 23:12:53 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 1 month ago (2015-11-12 05:12:08 UTC) #8
mtklein
lgtm Fixes the crash?
5 years, 1 month ago (2015-11-12 14:20:35 UTC) #9
herb_g
Add test cases for code.
5 years, 1 month ago (2015-11-12 16:34:35 UTC) #10
herb_g
Added test cases. PTAL
5 years, 1 month ago (2015-11-12 16:37:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438893002/20001
5 years, 1 month ago (2015-11-12 16:42:07 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 16:53:45 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/386127f1d431ef64bf655f39994f17daadfb5269

Powered by Google App Engine
This is Rietveld 408576698