Simulated Crash reporting for ErrAborted requests

net/url_request/url_request.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/compiler_specific.h"
+#include "base/debug/alias.h"
+#include "base/debug/dump_without_crashing.h"
 #include "base/debug/stack_trace.h"
 #include "base/lazy_instance.h"
 #include "base/memory/singleton.h"
 #include "base/message_loop/message_loop.h"
 #include "base/profiler/scoped_tracker.h"
+#include "base/rand_util.h"
 #include "base/stl_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/synchronization/lock.h"
 #include "base/values.h"
 #include "net/base/auth.h"
 #include "net/base/chunked_upload_data_stream.h"
 #include "net/base/host_port_pair.h"
 #include "net/base/load_flags.h"
 #include "net/base/load_timing_info.h"
 #include "net/base/net_errors.h"
@@ skipping 649 matching lines @@
   // This should only be called on a started request.
   if (!is_pending_ || !job_.get() || job_->has_response_started()) {
     NOTREACHED();
     return;
   }
   DoCancel(error, ssl_info);
 }
 
 void URLRequest::DoCancel(int error, const SSLInfo& ssl_info) {
   DCHECK(error < 0);
+  // ~500,000 ERR_ABORTED < 100ms in Canary channel a day. Sample .01% to get
+  // ~50 reports a day.
+  // TODO(csharrison) Remove this code when crbug.com/557430 is resolved.
+  int64 request_time =
+      (base::TimeTicks::Now() - creation_time_).InMilliseconds();
+  if (error == ERR_ABORTED && request_time <= 100 &&
+      load_flags_ & LOAD_MAIN_FRAME && base::RandDouble() < .0001) {
+    static int dump_times = 0;

[eroman, 2015/11/23 23:29:05]

This works on the assumption that URLRequest is only ever used from 1 thread.
Which I believe is true in Chrome

[mmenke, 2015/11/23 23:32:58]

I'm not in favor of adding more places that assume that...but given that we
shouldn't be keeping this around too long, think we can live with it.

+    if (dump_times < 5) {
+      char url_copy[256] = {0};
+      base::debug::Alias(&url_copy);

[eroman, 2015/11/23 23:29:05]

No need to alias twice (done below as well)

+      strncpy(url_copy, url().spec().c_str(), sizeof(url_copy));
+      base::debug::Alias(&url_copy);
+      base::debug::Alias(&request_time);
+      base::debug::DumpWithoutCrashing();
+      dump_times++;
+    }
+  }
   // If cancelled while calling a delegate, clear delegate info.
   if (calling_delegate_) {
     LogUnblocked();
     OnCallToDelegateComplete();
   }
 
   // If the URL request already has an error status, then canceling is a no-op.
   // Plus, we don't want to change the error status once it has been set.
   if (status_.is_success()) {
     status_ = URLRequestStatus(URLRequestStatus::CANCELED, error);
@@ skipping 502 matching lines @@
 }
 
 void URLRequest::GetConnectionAttempts(ConnectionAttempts* out) const {
   if (job_)
     job_->GetConnectionAttempts(out);
   else
     out->clear();
 }
 
 }  // namespace net