Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: src/core/SkPicturePlayback.h

Issue 143883006: No deduping dictionaries for matrices and regions. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: bump picture version Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkPictureFlat.h ('k') | src/core/SkPicturePlayback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkPicturePlayback.h
diff --git a/src/core/SkPicturePlayback.h b/src/core/SkPicturePlayback.h
index 6eb9ac3425767680edaaa09131b16b4ac3c39fb5..1cff0f9e0edd73518324c81b4666bc43f0b4368c 100644
--- a/src/core/SkPicturePlayback.h
+++ b/src/core/SkPicturePlayback.h
@@ -109,12 +109,8 @@ private:
return (*fBitmaps)[index];
}
- const SkMatrix* getMatrix(SkReader32& reader) {
- int index = reader.readInt();
- if (index == 0) {
- return NULL;
- }
- return &(*fMatrices)[index - 1];
+ void getMatrix(SkReader32& reader, SkMatrix* matrix) {
+ reader.readMatrix(matrix);
}
const SkPath& getPath(SkReader32& reader) {
@@ -151,9 +147,8 @@ private:
}
}
- const SkRegion& getRegion(SkReader32& reader) {
- int index = reader.readInt();
- return (*fRegions)[index - 1];
+ void getRegion(SkReader32& reader, SkRegion* region) {
+ reader.readRegion(region);
}
void getText(SkReader32& reader, TextContainer* text) {
@@ -169,7 +164,6 @@ public:
int bitmaps(size_t* size);
int paints(size_t* size);
int paths(size_t* size);
- int regions(size_t* size);
#endif
#ifdef SK_DEBUG_DUMP
@@ -210,9 +204,7 @@ private:
SkAutoTUnref<SkPathHeap> fPathHeap;
SkTRefArray<SkBitmap>* fBitmaps;
- SkTRefArray<SkMatrix>* fMatrices;
SkTRefArray<SkPaint>* fPaints;
- SkTRefArray<SkRegion>* fRegions;
SkData* fOpData; // opcodes and parameters
« no previous file with comments | « src/core/SkPictureFlat.h ('k') | src/core/SkPicturePlayback.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698