Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1438823002: Oilpan: handle WorkerObjectProxy::m_executionContext ref better. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kinuko+worker_chromium.org, falken, blink-worker-reviews_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: handle WorkerObjectProxy::m_executionContext ref better. The proxy object outlives its ExecutionContext reference; exempt it from any GC plugin checks. R= BUG=553613 Committed: https://crrev.com/1a57fcd05d963bcfda687e63b958602b1ced20f8 Cr-Commit-Position: refs/heads/master@{#359162}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/workers/WorkerObjectProxy.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sof
please take a look.
5 years, 1 month ago (2015-11-11 19:37:30 UTC) #2
haraken
LGTM (I'd replace it with UntracedMember (to enable the use-after-free detection) in the future though.)
5 years, 1 month ago (2015-11-11 19:39:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438823002/1
5 years, 1 month ago (2015-11-11 19:40:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/107257)
5 years, 1 month ago (2015-11-11 19:53:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438823002/1
5 years, 1 month ago (2015-11-11 20:22:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 21:37:54 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:00:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a57fcd05d963bcfda687e63b958602b1ced20f8
Cr-Commit-Position: refs/heads/master@{#359162}

Powered by Google App Engine
This is Rietveld 408576698