Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 1438803002: Skip test-run-machops/RunComputedCodeObject on AIX and PPC64BE. (Closed)

Created:
5 years, 1 month ago by MTBrandyberry
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Skip test-run-machops/RunComputedCodeObject on AIX and PPC64BE. This test, as written, is invalid on platforms which use function descriptors. See https://codereview.chromium.org/1377423002/ for background. R=mstarzinger@chromium.org, titzer@chromium.org, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/f83b8a61cfde22e488643440149d02d003622b15 Cr-Commit-Position: refs/heads/master@{#31967}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M test/cctest/cctest.status View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
MTBrandyberry
5 years, 1 month ago (2015-11-11 19:02:26 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438803002/1
5 years, 1 month ago (2015-11-11 20:22:31 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-11 20:42:37 UTC) #8
Michael Starzinger
LGTM (rubber-stamped, I am missing the background of why this is broken).
5 years, 1 month ago (2015-11-12 17:33:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438803002/1
5 years, 1 month ago (2015-11-12 19:08:57 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 19:10:35 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:20:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f83b8a61cfde22e488643440149d02d003622b15
Cr-Commit-Position: refs/heads/master@{#31967}

Powered by Google App Engine
This is Rietveld 408576698