Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1438773003: Fix GOOGLE3 Android build. (Closed)

Created:
5 years, 1 month ago by dogben
Modified:
5 years, 1 month ago
Reviewers:
mtklein
CC:
jcgregorio, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix GOOGLE3 Android build. DebugWriteToStderr isn't defined for Android. I'm not sure if I just didn't test compiling for Android or if this is due to a change in the base library. BUG=skia: No public API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/58afee8220b27f5a34f129f380f56b500da86c95

Patch Set 1 #

Patch Set 2 : Move SkDebugfForDumpStackTrace to SkPostConfig.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M include/core/SkPostConfig.h View 1 1 chunk +6 lines, -2 lines 0 comments Download
M src/core/SkDebug.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438773003/1
5 years, 1 month ago (2015-11-11 20:18:49 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-11 20:30:06 UTC) #4
dogben
5 years, 1 month ago (2015-11-11 20:30:57 UTC) #6
dogben
On 2015/11/11 at 20:30:57, Ben Wagner wrote: > Would still like a review on this.
5 years, 1 month ago (2015-11-12 23:20:15 UTC) #7
mtklein
lgtm
5 years, 1 month ago (2015-11-18 21:00:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438773003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438773003/20001
5 years, 1 month ago (2015-11-18 21:00:12 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 21:14:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/58afee8220b27f5a34f129f380f56b500da86c95

Powered by Google App Engine
This is Rietveld 408576698