Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1438753002: Ship --harmony-default-parameters (Closed)

Created:
5 years, 1 month ago by adamk
Modified:
5 years, 1 month ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ship --harmony-default-parameters BUG=v8:2160 LOG=y Committed: https://crrev.com/e752f964b645fc7aafd99fd684914a10831619e8 Cr-Commit-Position: refs/heads/master@{#31965}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
rossberg
lgtm
5 years, 1 month ago (2015-11-12 11:43:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438753002/1
5 years, 1 month ago (2015-11-12 15:57:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438753002/1
5 years, 1 month ago (2015-11-12 15:58:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 15:59:08 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:20:53 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e752f964b645fc7aafd99fd684914a10831619e8
Cr-Commit-Position: refs/heads/master@{#31965}

Powered by Google App Engine
This is Rietveld 408576698