Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1438733002: Do not attempt an Oilpan memory pressure GC if nested. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not attempt an Oilpan memory pressure GC if nested. Nested GCs aren't supported, so only trigger an urgent memory pressure GC if we're not sweeping up after another. R=haraken BUG= Committed: https://crrev.com/b60a822da76d4a3c619279082396eb60dfc487e6 Cr-Commit-Position: refs/heads/master@{#359127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look. Addressing https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win_Oilpan__dbg_/3254/layout-test-results/http/tests/xmlhttprequest/xmlhttprequest-json-response-overflow-crash-log.txt
5 years, 1 month ago (2015-11-11 15:44:13 UTC) #2
haraken
LGTM
5 years, 1 month ago (2015-11-11 16:09:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438733002/1
5 years, 1 month ago (2015-11-11 17:39:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 18:41:23 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 19:59:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b60a822da76d4a3c619279082396eb60dfc487e6
Cr-Commit-Position: refs/heads/master@{#359127}

Powered by Google App Engine
This is Rietveld 408576698