Remove -fomit-frame-pointer when building with any Sanitizer.

Remove -fomit-frame-pointer when building with any Sanitizer.

On Android/ARM we add -fomit-frame-pointer elsewhere in common.gypi.
Simply adding -fno-omit-frame-pointer when building with sanitizers is
not enough, because the former flag wins (it get added closer to the end
of the command line). Therefore, we also remove all -fomit-frame-pointer
flags under sanitizers.

BUG=325685
TEST=wait for the next clang roll, run asan tests on android
R=glider@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246256

[Alexander Potapenko, 2014-01-22 09:22:11]

LGTM

On Wed, Jan 22, 2014 at 1:20 PM,  <eugenis@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Remove -fomit-frame-pointer when building with any Sanitizer.
>
> On Android/ARM we add -fomit-frame-pointer elsewhere in common.gypi.
> Simply adding -fno-omit-frame-pointer when building with sanitizers is
> not enough, because the former flag wins (it get added closer to the end
> of the command line). Therefore, we also remove all -fomit-frame-pointer
> flags under sanitizers.
>
> BUG=325685
> TEST=wait for the next clang roll, run asan tests on android
>
> Please review this at https://codereview.chromium.org/143873009/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+3, -0 lines):
>   M build/common.gypi
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index
>
7312a4659c8a10aa949d00409bb8efd95a153ce2..270d333e3b9e84ed1b990f977d3eab157a95539f
> 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -3418,6 +3418,9 @@
>                    '-fno-omit-frame-pointer',
>                    '-gline-tables-only',
>                  ],
> +                'cflags!': [
> +                  '-fomit-frame-pointer',
> +                ],
>                  'ldflags!': [
>                    # Functions interposed by the sanitizers can make ld
> think
>                    # that some libraries aren't needed when they actually
> are,
>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[eugenis, 2014-01-22 09:27:58]

Committed patchset #1 manually as r246256 (presubmit successful).