Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 14387004: Fix segmentation fault in CodeMap::Print (Closed)

Created:
7 years, 8 months ago by yurys
Modified:
7 years, 8 months ago
Reviewers:
loislo, alph, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix segmentation fault in CodeMap::Print CodeEntry* is always NULL for SharedFunctionInfo entries in the CodeMap. Take this into account when printing the map. Drive-by: removed CodeEntry::shared_id() which is never called. BUG=None Committed: https://code.google.com/p/v8/source/detail?r=14410

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/profile-generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/profile-generator.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years, 8 months ago (2013-04-24 11:58:17 UTC) #1
Jakob Kummerow
LGTM with a nit. https://codereview.chromium.org/14387004/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): https://codereview.chromium.org/14387004/diff/1/src/profile-generator.cc#newcode576 src/profile-generator.cc:576: OS::Print("%p SharedFunctionInfo %d\n", key, value.size); ...
7 years, 8 months ago (2013-04-24 12:00:41 UTC) #2
yurys
https://codereview.chromium.org/14387004/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): https://codereview.chromium.org/14387004/diff/1/src/profile-generator.cc#newcode576 src/profile-generator.cc:576: OS::Print("%p SharedFunctionInfo %d\n", key, value.size); On 2013/04/24 12:00:41, Jakob ...
7 years, 8 months ago (2013-04-24 12:07:42 UTC) #3
yurys
7 years, 8 months ago (2013-04-24 12:09:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r14410 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698