Issue 1438633002: js_ast: Avoid precedence issue with negative numbers as receivers at calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1438633002: js_ast: Avoid precedence issue with negative numbers as receivers at calls (Closed)

Created:
5 years, 1 month ago by sra1

Modified:
5 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

js_ast: Avoid precedence issue with negative numbers as receivers at calls This change makes LiteralNumber and DeferredNumber have a precedence based on the value so that the sign always binds to the number. An alternative is to change constant generation to built the negation of a positive constant, but this approach does not work for deferred numbers since the sign is unknown at AST generation time. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/2d60a9cf4562b1ae59bfc0cecd63039cc4180fd2

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -50 lines)			Patch
M	pkg/js_ast/lib/src/nodes.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	pkg/js_ast/lib/src/printer.dart	View	3 chunks	+9 lines, -3 lines	0 comments	Download
A +	tests/compiler/dart2js/js_constant_test.dart	View	2 chunks	+3 lines, -46 lines	0 comments	Download
A	tests/compiler/dart2js_native/js_constant_test.dart	View	1 chunk	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sra1

5 years, 1 month ago (2015-11-11 03:02:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2d60a9cf4562b1ae59bfc0cecd63039cc4180fd2 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages