Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 14386011: Fix recognition of factories (for setting result cid) and add them to checks. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_builder.h ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 22079)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -2046,27 +2046,6 @@
}
-// List of recognized list factories in core lib:
-// (factory-name-symbol, result-cid, fingerprint).
-// TODO(srdjan): Store the values in the snapshot instead.
-#define RECOGNIZED_LIST_FACTORY_LIST(V) \
- V(ObjectArrayFactory, kArrayCid, 97987288) \
- V(GrowableObjectArrayWithData, kGrowableObjectArrayCid, 816132033) \
- V(GrowableObjectArrayFactory, kGrowableObjectArrayCid, 552407276) \
- V(Int8ListFactory, kTypedDataInt8ArrayCid, 1299195009) \
- V(Uint8ListFactory, kTypedDataUint8ArrayCid, 1493118613) \
- V(Uint8ClampedListFactory, kTypedDataUint8ClampedArrayCid, 642014193) \
- V(Int16ListFactory, kTypedDataInt16ArrayCid, 1346619471) \
- V(Uint16ListFactory, kTypedDataUint16ArrayCid, 1374024153) \
- V(Int32ListFactory, kTypedDataInt32ArrayCid, 1583592980) \
- V(Uint32ListFactory, kTypedDataUint32ArrayCid, 1940214615) \
- V(Int64ListFactory, kTypedDataInt64ArrayCid, 108181413) \
- V(Uint64ListFactory, kTypedDataUint64ArrayCid, 375587484) \
- V(Float64ListFactory, kTypedDataFloat64ArrayCid, 919047725) \
- V(Float32ListFactory, kTypedDataFloat32ArrayCid, 1038684997) \
- V(Float32x4ListFactory, kTypedDataFloat32x4ArrayCid, 801641591) \
-
-
// Class that recognizes factories and returns corresponding result cid.
class FactoryRecognizer : public AllStatic {
public:
« no previous file with comments | « runtime/vm/flow_graph_builder.h ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698